Test #770
Closed
Test #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore(deps): update ci dependencies * Update catalogValidationValues.json.template --------- Co-authored-by: Conall Ó Cofaigh <[email protected]>
… new input variable `operating_system` (terraform-ibm-modules#436)
…-modules#451) Co-authored-by: [email protected] <[email protected]> Co-authored-by: Aashiq-J <[email protected]>
…rotection` to consider use case when data lookup checks current default version (terraform-ibm-modules#455)
* fix(deps): update terraform-module * fix the minimum provider version required to 1.66.0 (terraform-ibm-modules#453) * update version in fscloud --------- Co-authored-by: Aashiq-J <[email protected]> Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Aashiq-J <[email protected]>
…IBM Cloud private endpoints for use cases where the runtime may not have access to the public network. This can be achieved by setting the `use_private_endpoint` variable to `true`.<br>- As part of this effort the `ibmcloud_api_key` input variable has been removed as an input for the module. (terraform-ibm-modules#442)
…everyone will have an entitlement that can be used (terraform-ibm-modules#454)
…odules#469) * fix: fixed advanced example to handle ingress check SKIP UPGRADE TEST * fix: fixed gateways
…e inside the `worker_pools` input variable list object. Validation has also been added to ensure only the following allowed values are passed: `REDHAT_8_64`, `RHCOS` (only allowed in OCP version 4.15 or later) (terraform-ibm-modules#466)
…terratest-wrapper to v1.35.4 (terraform-ibm-modules#488)
…ra (terraform-ibm-modules#732) Co-authored-by: akocbek <[email protected]>
… a cluster with a public endpoint enabled by default. This can be toggled using the `disable_public_service_endpoint` input.<br>- If VPC DA is selected (it is by default), there is now an option to configure the network ACLs. By default, it will create ACLs to allow public (port 80 and 443) so the Openshift console can be reached.(terraform-ibm-modules#740)
…tance_crn`, `existing_cluster_kms_key_crn` and `existing_boot_volume_kms_key_crn` inputs (terraform-ibm-modules#751)
Co-authored-by: Arya Girish K <[email protected]>
…`, which means it will default to the default resource group in your account. Previously it was defaulting to "Default" which may not exist in every account. (terraform-ibm-modules#766)
* feat: Quickstart OCP DA * Updated catalog,variables.tf,main.tf,pr_test.go * Added catalogValidationValues.json.template * fix: Resolved pipeline error * Removed log file * fix: Defined Resourcegroup in pr_test * Resolved precommit error * updated code * Removed logfile * Addressed review comments * Updated catalog * SKIP UPGRADE TEST * Updated permission * Addressed review comments * Adressed review comments * Addressed review comments * Addressed review comments * Updated code * Addressed comments * Updated decsription * Addressed review comments * Updated diagram * Addressed review comments * Updated mark down file and variable.tf * resolved review comments * addressed review comments * Update ibm_catalog.json Co-authored-by: Shikha Maheshwari <[email protected]> * Update ibm_catalog.json Co-authored-by: Shikha Maheshwari <[email protected]> * Update solutions/quickstart/variables.tf Co-authored-by: Shikha Maheshwari <[email protected]> * Addressed comments * Updated catalog validation,resource_group an output.tf * Resolved precommit error --------- Co-authored-by: Arya Girish K <[email protected]> Co-authored-by: Shikha Maheshwari <[email protected]>
|
Closing this PR. Raised by mistake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
21 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers