chore: Address ROKS DA E2E walkthrough feedback #771

arya-girish-k · 2025-08-12T08:01:39Z

Description

https://github.ibm.com/GoldenEye/issues/issues/15542

Add the keyword "ROKS" to OCP DA
In diagram KMS -> Key Protect
Updated description for dependant DA.

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

arya-girish-k · 2025-08-12T09:34:24Z

/run pipeline

arya-girish-k · 2025-08-13T09:39:25Z

/run pipeline

ocofaigh

You cant just go updating the versions of all of the DA add-ons - it will break something. The same DA versions needs to be used across all of the dependant DAs that are defined. We are in the process of rolling out updates to all dependant DA - Vipin will eventually be updating this DA. Please remove the changes you made to updating DA versions - I'm not sure why this was done in this PR?

I also noticed that the diagram says "Key for registry bucket" - this is NOT true. The registry bucket cant even be encrypted (we don't create it in this DA). The Key Protect key is used for encrypting the cluster and the boot volumes used by the cluster

ibm_catalog.json

Co-authored-by: Shikha Maheshwari <[email protected]>

arya-girish-k · 2025-08-19T04:37:48Z

/run pipeline

ibm_catalog.json

pranjali-mundra · 2025-08-19T17:35:27Z

ibm_catalog.json

            {
              "name": "deploy-arch-ibm-kms",
-              "description": "Enable Cloud Automation for Key Protect when you want services to use your own managed encryption keys. If disabled, it will fall back on IBM Cloud's default service-managed encryption. ",
+              "description": "Configure Key Protect to use your own managed encryption keys for Object Storage bucket.",


Configures Key Protect to manage and use encryption keys for COS bucket.

Updated architecture description for fully configurable DA as well.

ibm_catalog.json

pranjali-mundra · 2025-08-19T17:44:04Z

ibm_catalog.json

                  "type": "image/svg+xml"
                },
-                "description": "This QuickStart variation of deployable architecture enables deployment of a <b>Red Hat OpenShift cluster</b> within an IBM Cloud Virtual Private Cloud (VPC). It provisions the OpenShift cluster and its foundational VPC infrastructure with a limited set of essential options for rapid and streamlined setup. Additionally, the deployment creates an <b>Object Storage bucket</b> that serves as the internal container image registry for the OpenShift cluster. Thus, it helps ensure seamless storage integration.<br><br>Users can select from predefined cluster sizes — <b>mini (default), small, medium, and large.</b> Each size determining the number of availability zones, worker nodes per zone, and the <b>machine type</b> (worker node flavor). [Learn more](https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/blob/main/solutions/quickstart/DA_docs.md).<br><br>By default, the architecture provisions a <b>two-zone VPC</b>, forming the foundation for the OpenShift cluster. The cluster comprises a single worker pool distributed across these zones, with <b>two worker nodes per zone</b> in the mini configuration.<br><br>This streamlined architecture balances ease of use with flexibility, enabling rapid OpenShift cluster deployments with the infrastructure, integrated storage services, and right-sized compute resources of IBM Cloud."
+                "description": "This QuickStart variation of deployable architecture enables deployment of a <b>Red Hat OpenShift cluster</b> within an IBM Cloud Virtual Private Cloud (VPC). It provisions the OpenShift cluster and its foundational VPC infrastructure with a limited set of essential options for rapid and streamlined setup. Additionally, the deployment creates an <b>Object Storage bucket</b> that serves as the internal container image registry for the OpenShift cluster. Thus, it helps ensure seamless storage integration.<br><br>Users can select from predefined cluster sizes — <b>mini (default), small, medium, and large.</b> Each size determines the number of availability zones, worker nodes per zone, and the <b>machine type</b> (worker node flavor). [Learn more](https://github.com/terraform-ibm-modules/terraform-ibm-base-ocp-vpc/blob/main/solutions/quickstart/DA_docs.md).<br><br>By default, the architecture provisions a <b>two-zone VPC</b>, forming the foundation for the OpenShift cluster. The cluster comprises a single worker pool distributed across these zones, with <b>two worker nodes per zone</b> in the mini configuration.<br><br>This streamlined architecture balances ease of use with flexibility, enabling rapid OpenShift cluster deployments with the infrastructure, integrated storage services, and right-sized compute resources of IBM Cloud."


This QuickStart FSCloud variation of deployable architecture enables deployment of a Red Hat OpenShift cluster within an IBM Cloud Virtual Private Cloud (VPC). It provisions the OpenShift cluster and its foundational VPC infrastructure with a limited set of essential options for rapid and streamlined setup. Additionally, the deployment creates an Object Storage bucket that serves as the internal container image registry for the OpenShift cluster. Thus, it helps ensure seamless storage integration.

Users can select from predefined cluster sizes — mini (default), small, medium, and large. Each size determines the number of availability zones, worker nodes per zone, and the machine type (worker node flavor). Learn more.

By default, the architecture provisions a two-zone VPC, forming the foundation for the OpenShift cluster. The cluster comprises a single worker pool distributed across these zones, with two worker nodes per zone in the mini configuration.

This streamlined architecture balances ease of use with flexibility, enabling rapid OpenShift cluster deployments with the infrastructure, integrated storage services, and right-sized compute resources of IBM Cloud.

Quickstart is the variation name used in this module, so the description will remain unchanged.

Co-authored-by: Shikha Maheshwari <[email protected]>

ibm_catalog.json

maheshwarishikha

Service official name is Event Notifications - please use the same in diagram.

Co-authored-by: Shikha Maheshwari <[email protected]>

arya-girish-k · 2025-08-21T06:09:55Z

Service official name is Event Notifications - please use the same in diagram.

Updated in the diagram

arya-girish-k · 2025-08-21T06:20:27Z

/run pipeline

arya-girish-k · 2025-08-21T06:37:01Z

/run pipeline

maheshwarishikha

LGTM

Feedback addressed

terraform-ibm-modules-ops · 2025-08-21T08:57:41Z

🎉 This PR is included in version 3.55.4 🎉

The release is available on:

GitHub release
v3.55.4

Your semantic-release bot 📦🚀

fix: Address ROKS DA E2E walkthrough feedback

93e8bdb

arya-girish-k changed the title ~~fix: Address ROKS DA E2E walkthrough feedback~~ [WIP]fix: Address ROKS DA E2E walkthrough feedback Aug 12, 2025

update version

f442160

arya-girish-k marked this pull request as ready for review August 12, 2025 13:05

arya-girish-k requested review from Aashiq-J and toddgiguere as code owners August 12, 2025 13:05

Merge branch 'main' into issue-15542

cacf105

arya-girish-k changed the title ~~[WIP]fix: Address ROKS DA E2E walkthrough feedback~~ chore: Address ROKS DA E2E walkthrough feedback Aug 13, 2025

ocofaigh previously requested changes Aug 13, 2025

View reviewed changes

Arya Girish K added 2 commits August 18, 2025 18:25

Addressed review comments

bae4699

Reverted vversion

ab91882

maheshwarishikha reviewed Aug 18, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

maheshwarishikha reviewed Aug 18, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

maheshwarishikha reviewed Aug 18, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

maheshwarishikha reviewed Aug 18, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

arya-girish-k and others added 4 commits August 18, 2025 22:10

Update ibm_catalog.json

3c85667

Co-authored-by: Shikha Maheshwari <[email protected]>

Update ibm_catalog.json

a83882f

Co-authored-by: Shikha Maheshwari <[email protected]>

Update ibm_catalog.json

7aee5e2

Co-authored-by: Shikha Maheshwari <[email protected]>

Addressing Review comments

12d4c1e

Updated description

8e80ae3

pranjali-mundra reviewed Aug 19, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

pranjali-mundra reviewed Aug 19, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

pranjali-mundra reviewed Aug 19, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

pranjali-mundra reviewed Aug 19, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

pranjali-mundra reviewed Aug 19, 2025

View reviewed changes

Addressed Review comments

9f21900

arya-girish-k and others added 6 commits August 20, 2025 15:10

Update ibm_catalog.json

9e63900

Co-authored-by: Shikha Maheshwari <[email protected]>

Update ibm_catalog.json

77346eb

Co-authored-by: Shikha Maheshwari <[email protected]>

Update ibm_catalog.json

d91e47d

Co-authored-by: Shikha Maheshwari <[email protected]>

Update ibm_catalog.json

4c66acf

Co-authored-by: Shikha Maheshwari <[email protected]>

Update ibm_catalog.json

3a4aa66

Co-authored-by: Shikha Maheshwari <[email protected]>

updated catalog

8e5c0b3

vburckhardt previously requested changes Aug 20, 2025

View reviewed changes

Arya Girish K added 3 commits August 20, 2025 23:10

Addressed Review comments

016ce8a

Update diagram

0ad0ef4

Addressed review comments

6ff9871

maheshwarishikha reviewed Aug 21, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

maheshwarishikha reviewed Aug 21, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

maheshwarishikha reviewed Aug 21, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

maheshwarishikha reviewed Aug 21, 2025

View reviewed changes

ibm_catalog.json Outdated Show resolved Hide resolved

maheshwarishikha requested changes Aug 21, 2025

View reviewed changes

arya-girish-k and others added 4 commits August 21, 2025 10:51

Update ibm_catalog.json

804b6dd

Co-authored-by: Shikha Maheshwari <[email protected]>

Update ibm_catalog.json

81a360a

Co-authored-by: Shikha Maheshwari <[email protected]>

Update ibm_catalog.json

13def3a

Co-authored-by: Shikha Maheshwari <[email protected]>

Addressed review comments

6ec7276

Updated catalog

3271944

maheshwarishikha approved these changes Aug 21, 2025

View reviewed changes

maheshwarishikha merged commit 39d65ba into main Aug 21, 2025
2 checks passed

maheshwarishikha deleted the issue-15542 branch August 21, 2025 08:56

terraform-ibm-modules-ops added the released label Aug 21, 2025

chore: Address ROKS DA E2E walkthrough feedback #771

chore: Address ROKS DA E2E walkthrough feedback #771

Uh oh!

Conversation

arya-girish-k commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

Uh oh!

arya-girish-k commented Aug 12, 2025

Uh oh!

arya-girish-k commented Aug 13, 2025

Uh oh!

ocofaigh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

arya-girish-k commented Aug 19, 2025

Uh oh!

Uh oh!

pranjali-mundra Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

arya-girish-k Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

arya-girish-k Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

arya-girish-k Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pranjali-mundra Aug 19, 2025

Choose a reason for hiding this comment

Uh oh!

arya-girish-k Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

arya-girish-k Aug 20, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

maheshwarishikha left a comment

Choose a reason for hiding this comment

Uh oh!

arya-girish-k commented Aug 21, 2025

Uh oh!

arya-girish-k commented Aug 21, 2025

Uh oh!

arya-girish-k commented Aug 21, 2025

arya-girish-k commented Aug 12, 2025 •

edited

Loading

ocofaigh left a comment •

edited

Loading