Skip to content

Conversation

@piyush117
Copy link
Contributor

Description

issue: https://github.ibm.com/GoldenEye/issues/issues/15518

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117
Copy link
Contributor Author

Tested base-ocp-vpc successfully after creating a dev tile,
attaching the SS for the changes made
Screenshot 2025-08-20 at 4 38 42 PM
Screenshot 2025-08-20 at 4 38 52 PM
Screenshot 2025-08-20 at 4 39 02 PM
Screenshot 2025-08-20 at 4 40 05 PM

Copy link
Member

@imprateeksh imprateeksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush117 - FYI - As a regular practice, we do not commit common-dev-assets changes as part of individual PRs (unless asked).
This is updated automatically via renovate PRs in main branch. We then merge latest main changes in our respective feature branch.

…-base-ocp-vpc into 15518-hcl-editor-for-listobject
…m-ibm-modules/terraform-ibm-base-ocp-vpc into 15518-hcl-editor-for-listobject
@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117
Copy link
Contributor Author

piyush117 commented Aug 21, 2025

Hi @imprateeksh, the changes that I made required the latest common-dev-assets which was not updated as part of Renovate PR and since I needed this PR on high priority I had to commit it.

@imprateeksh
Copy link
Member

Hi @imprateeksh, the changes that I made required the latest common-dev-assets which was not updated as part of Renovate PR and since I needed this PR on high priority I had to commit it.

Got it. This was just for your information.

@piyush117
Copy link
Contributor Author

/run pipeline

…-base-ocp-vpc into 15518-hcl-editor-for-listobject
@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 1, 2025

@piyush117 please resolve conflicts

…m-ibm-modules/terraform-ibm-base-ocp-vpc into 15518-hcl-editor-for-listobject
@piyush117
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 1ff2d44 into main Sep 2, 2025
2 checks passed
@ocofaigh ocofaigh deleted the 15518-hcl-editor-for-listobject branch September 2, 2025 09:05
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.55.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants