Skip to content

added next steps #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 25, 2025
Merged

added next steps #781

merged 15 commits into from
Sep 25, 2025

Conversation

@whoffler
Copy link
Contributor

Description

for issue - https://github.ibm.com/GoldenEye/issues/issues/13756#issuecomment-129327509

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@whoffler
Copy link
Contributor Author

/run pipeline

ocofaigh
ocofaigh reviewed Aug 27, 2025
View reviewed changes
solutions/quickstart/outputs.tf Outdated
}

output "next_step_primary_url" {
value = "https://cloud.ibm.com/containers/cluster-management/clusters/${module.ocp_base.cluster_id}/overview"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the Openshift dashbaord. This is the IBM Cloud cluster console page. The Openshift dashboard is based off the ingress domain. Perhaps we could keep this as a secondary one though

ocofaigh
ocofaigh requested changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get the wording reviewed by the docs team please. Also lets add to Fully configurable variation too

@ocofaigh
Copy link
Contributor

ocofaigh commented Sep 1, 2025

@pranjali-mundra Can you review the wording here please and approve if happy?

whoffler
whoffler commented Sep 1, 2025
View reviewed changes
@rajatagarwal-ibm
Copy link
Member

/run pipeline

@rajatagarwal-ibm
Copy link
Member

The format of the OpenShift Console URL is

https://console-openshift-console.${ingress_hostname}/dashbaords

I have updated the code to fix it.

ocofaigh
ocofaigh requested changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording here needs to be reviewed by docs team, but for sure I would change this in the several places its mentioned:

Openshift Cluster -> Red Hat OpenShift cluster

ocofaigh
ocofaigh requested changes Sep 15, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to make same changes to fully configurable variation in this repo and also then in the quickstart and standard variations in https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone

@rajatagarwal-ibm
Copy link
Member

I have updated this PR, if the changes are good then I will make similar changes in the landing zone VPC module too.

ocofaigh
ocofaigh requested changes Sep 17, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have 1 minor comment - @pranjali-mundra can you please review the wording here?

pranjali-mundra
pranjali-mundra reviewed Sep 23, 2025
View reviewed changes
pranjali-mundra
pranjali-mundra reviewed Sep 23, 2025
View reviewed changes
@rajatagarwal-ibm
Copy link
Member

/run pipeline

@ocofaigh ocofaigh merged commit 08d646f into main Sep 25, 2025
2 checks passed
@ocofaigh ocofaigh deleted the nextSteps branch September 25, 2025 10:54
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.61.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajatagarwal-ibm rajatagarwal-ibm rajatagarwal-ibm left review comments

@ocofaigh ocofaigh ocofaigh approved these changes

@toddgiguere toddgiguere Awaiting requested review from toddgiguere toddgiguere is a code owner

@Aashiq-J Aashiq-J Awaiting requested review from Aashiq-J Aashiq-J is a code owner

+1 more reviewer

@pranjali-mundra pranjali-mundra pranjali-mundra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@whoffler @ocofaigh @rajatagarwal-ibm @terraform-ibm-modules-ops @pranjali-mundra