-
Couldn't load subscription status.
- Fork 13
doc: create markdown doc for supported variations #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
reference-architecture/deploy-arch-ibm-ocp-fully-configurable.md
Outdated
Show resolved
Hide resolved
reference-architecture/deploy-arch-ibm-ocp-fully-configurable.md
Outdated
Show resolved
Hide resolved
reference-architecture/deploy-arch-ibm-ocp-fully-configurable.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The folder needs to be named reference-architectures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imprateeksh A few things to fix please
reference-architectures/deploy-arch-ibm-ocp-fully-configurable.md
Outdated
Show resolved
Hide resolved
reference-architectures/deploy-arch-ibm-ocp-fully-configurable.md
Outdated
Show resolved
Hide resolved
| related_links: | ||
| - title: "Landing zone for containerized applications with OpenShift" | ||
| url: "https://cloud.ibm.com/docs/deployable-reference-architectures?topic=deployable-reference-architectures-ocp-fully-configurable" | ||
| description: "A deployable architecture that delivers a scalable and flexible Red Hat OpenShift environment on IBM Cloud Virtual Private Cloud (VPC), with seamless integration to security, observability, and other foundational services for containerized workloads." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have been including all the variations in here, so suggest to also add:
- title: "Landing zone for containerized applications with OpenShift (Standard - Integrated setup with configurable services)"
url: "https://cloud.ibm.com/docs/deployable-reference-architectures?topic=deployable-reference-architectures-ocp-fully-configurable"
description: "A deployable architecture that delivers a scalable and flexible Red Hat OpenShift environment on IBM Cloud Virtual Private Cloud (VPC), with seamless integration to security, observability, and other foundational services for containerized workloads."
- title: "Landing zone for containerized applications with OpenShift (QuickStart - Basic and simple)"
url: "https://cloud.ibm.com/docs/secure-infrastructure-vpc?topic=secure-infrastructure-ocp-ra-qs"
description: "A deployable architecture solution that is based on the IBM Cloud for Financial Services reference architecture. This solution delivers a scalable and flexible Red Hat OpenShift environment on IBM Cloud Virtual Private Cloud (VPC), with seamless integration to security, observability, and other foundational services for containerized workloads."
- title: "Landing zone for containerized applications with OpenShift (Standard - Financial Services edition)"
url: "https://cloud.ibm.com/docs/deployable-reference-architectures?topic=deployable-reference-architectures-ocp-ra"
description: "A deployable architecture that creates a secure and compliant Red Hat OpenShift Container Platform workload clusters on a Virtual Private Cloud (VPC) network based on the IBM Cloud for Financial Services reference architecture."
- title: "Landing zone for containerized applications with OpenShift (QuickStart - Financial Services edition)"
url: "https://cloud.ibm.com/docs/deployable-reference-architectures?topic=deployable-reference-architectures-roks-ra-qs"
description: "An introductory, non-certified deployment aligned with the Financial Services Cloud VPCs topology. Not suitable for production workloads or upgrade paths."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So all these will be part of related links? And does Quickstart variation should also have these links under related_links?
Also, I made change to name for fully configurable as:
Landing zone for containerized applications with OpenShift - Standard - Integrated setup with configurable services
but above it is mentioned like:
"Landing zone for containerized applications with OpenShift (Standard - Integrated setup with configurable services)"
Similarly for Quick start variation, I am using name as :
Landing zone for containerized applications with OpenShift - QuickStart variation
But above we have two titles:
a) "Landing zone for containerized applications with OpenShift (QuickStart - Basic and simple)"
b) "Landing zone for containerized applications with OpenShift (QuickStart - Financial Services edition)"
What should be done here @ocofaigh ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what we have everywhere else currently yes - We can double check with the docs contact to confirm, but right now lets be consistent with the other reference architectures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added this in both variations for now. I am not sure about what the correct links should be.
e.g Last one points to VPC (LZ) quick start page -
url: "https://cloud.ibm.com/docs/deployable-reference-architectures?topic=deployable-reference-architectures-roks-ra-qs"
reference-architectures/deploy-arch-ibm-ocp-fully-configurable.md
Outdated
Show resolved
Hide resolved
|
@imprateeksh Please work with Pranjali to review this. Once content team approve, I'll merge |
reference-architectures/deploy-arch-ibm-ocp-fully-configurable.md
Outdated
Show resolved
Hide resolved
reference-architectures/deploy-arch-ibm-ocp-fully-configurable.md
Outdated
Show resolved
Hide resolved
reference-architectures/deploy-arch-ibm-ocp-fully-configurable.md
Outdated
Show resolved
Hide resolved
reference-architectures/deploy-arch-ibm-ocp-fully-configurable.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@imprateeksh version is final - it must be updated in the docs here to 3.58.1 please
…raform-ibm-base-ocp-vpc into 15761-ref-arch
|
Addressed all review comments. One point was suggested by @pranjali-mundra about having same columns as in other documents. |
|
@imprateeksh Sorry we had to create patch release 3.58.2 - please update |
…raform-ibm-base-ocp-vpc into 15761-ref-arch
|
/run pipeline |
|
🎉 This PR is included in version 3.59.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Issue Reference - #15761
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers