Skip to content

feat: bump to helm v3 #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2025
Merged

feat: bump to helm v3 #787

merged 3 commits into from
Sep 11, 2025

Conversation

@kierramarie
Copy link
Member

@kierramarie kierramarie commented Sep 5, 2025 •
edited
Loading

Description

Bump terraform helm version to v3 and update relevant syntaxes to match.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@kierramarie
Copy link
Member Author

/run pipeline

@kierramarie
Copy link
Member Author

kierramarie commented Sep 5, 2025 •
edited
Loading

module.kube_audit[0].helm_release.kube_audit
changes:

  • id removed
  • metadata removed
  • set_wo_revision changed from 1 to null
Messages:   	Resource(s) identified to be updated 
        	            	Name: kube_audit
        	            	Address: module.kube_audit[0].helm_release.kube_audit
        	            	Actions: [update]
        	            	DIFF:
        	            	  Before: 
        	            		{
                                          "id":"ibmcloud-kube-audit",
                                          "metadata":{"app_version":"1.0.0","chart":"kube-audit","first_deployed":1757085915,"last_deployed":1757085915,"name":"ibmcloud-kube-audit","namespace":"default","notes":"","revision":1,"values":"{}","version":"0.0.1"},
                                          "postrender":"SECURE_VALUE_HIDDEN_HASH:-39ed240416ee7e15139f821632fcd8f940c9b9395a8f10110c21c04b","set":"SECURE_VALUE_HIDDEN_HASH:-ff32f6503f757c56f4f26a66e07e97f832af88a641fbca835449c513",
                                          "set_list":"SECURE_VALUE_HIDDEN_HASH:-c21738a434edbb1e3b8274fc7af1bb4416db21a17595402bc465b5f2",
                                          "set_sensitive":"SECURE_VALUE_HIDDEN_HASH:-2ff4c7c51ab985cdca10be2ed0c2213e783bacbb70d5800982499f51",
                                          "set_wo_revision":1
                                        }
        	            	  After: 
        	            		{
                                        "postrender":"SECURE_VALUE_HIDDEN_HASH:-8fe4bcc0b5b9d770f965f26ad91c84a6b9d2d6e9a3765049418cc667",
                                        "set":"SECURE_VALUE_HIDDEN_HASH:-962859f27bbb33579ad94163d946789a1d2f31f9bb9ac613d5ff86a6",
                                        "set_list":"SECURE_VALUE_HIDDEN_HASH:-da3ed0de010a8459697f71aa244d2685ebb7583aa64b536c6c6353fe",
                                        "set_sensitive":"SECURE_VALUE_HIDDEN_HASH:-e7d7d31c823339be91eabb350f3b1e5f7c1e0ab1faf82a5e0702b882",
                                        "set_wo_revision":null
                                      }
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "update"
        	            	  ],
        	            	  "after": {
        	            	    "atomic": false,
        	            	    "chart": "../../modules/kube-audit/helm-charts/kube-audit",
        	            	    "cleanup_on_fail": false,
        	            	    "create_namespace": false,
        	            	    "dependency_update": false,
        	            	    "description": null,
        	            	    "devel": null,
        	            	    "disable_crd_hooks": false,
        	            	    "disable_openapi_validation": false,
        	            	    "disable_webhooks": false,
        	            	    "force_update": true,
        	            	    "keyring": null,
        	            	    "lint": false,
        	            	    "manifest": null,
        	            	    "max_history": 0,
        	            	    "name": "ibmcloud-kube-audit",
        	            	    "namespace": "default",
        	            	    "pass_credentials": false,
        	            	    "postrender": "SECURE_VALUE_HIDDEN_HASH:-c7856f1acef9b3465dbfbe237228c12c23768005d0b547777c76d0d2",
        	            	    "recreate_pods": true,
        	            	    "render_subchart_notes": true,
        	            	    "replace": false,
        	            	    "repository": null,
        	            	    "repository_ca_file": null,
        	            	    "repository_cert_file": null,
        	            	    "repository_key_file": null,
        	            	    "repository_password": "SECURE_VALUE_HIDDEN_HASH:-064cd5341f6337b5b433d31dd7a25512f82a18087eacfed8c2370fed",
        	            	    "repository_username": null,
        	            	    "reset_values": false,
        	            	    "reuse_values": false,
        	            	    "set": "SECURE_VALUE_HIDDEN_HASH:-711254be15e9b2e78ffc58af24cd9813185720367b371484f6432f35",
        	            	    "set_list": "SECURE_VALUE_HIDDEN_HASH:-981f979b0188ce70ada8d98c4227b2fe063865b12c90fa275b6db77f",
        	            	    "set_sensitive": "SECURE_VALUE_HIDDEN_HASH:-859f843865bf4283354b72ae5a27cd9ab4261069d72cb9f386005578",
        	            	    "set_wo": null,
        	            	    "set_wo_revision": null,
        	            	    "skip_crds": false,
        	            	    "status": "deployed",
        	            	    "timeout": 1200,
        	            	    "values": null,
        	            	    "verify": false,
        	            	    "version": "0.0.1",
        	            	    "wait": true,
        	            	    "wait_for_jobs": false
        	            	  },
        	            	  "after_identity": {
        	            	    "namespace": "default",
        	            	    "release_name": "ibmcloud-kube-audit"
        	            	  },
        	            	  "after_sensitive": {
        	            	    "metadata": {},
        	            	    "repository_password": true,
        	            	    "set": [
        	            	      {},
        	            	      {},
        	            	      {},
        	            	      {}
        	            	    ]
        	            	  },
        	            	  "after_unknown": {
        	            	    "id": true,
        	            	    "metadata": true,
        	            	    "set": [
        	            	      {},
        	            	      {},
        	            	      {},
        	            	      {}
        	            	    ]
        	            	  },
        	            	  "before": {
        	            	    "atomic": false,
        	            	    "chart": "../../modules/kube-audit/helm-charts/kube-audit",
        	            	    "cleanup_on_fail": false,
        	            	    "create_namespace": false,
        	            	    "dependency_update": false,
        	            	    "description": null,
        	            	    "devel": null,
        	            	    "disable_crd_hooks": false,
        	            	    "disable_openapi_validation": false,
        	            	    "disable_webhooks": false,
        	            	    "force_update": true,
        	            	    "id": "ibmcloud-kube-audit",
        	            	    "keyring": null,
        	            	    "lint": false,
        	            	    "manifest": null,
        	            	    "max_history": 0,
        	            	    "metadata": {
        	            	      "app_version": "1.0.0",
        	            	      "chart": "kube-audit",
        	            	      "first_deployed": 1757085915,
        	            	      "last_deployed": 1757085915,
        	            	      "name": "ibmcloud-kube-audit",
        	            	      "namespace": "default",
        	            	      "notes": "",
        	            	      "revision": 1,
        	            	      "values": "{}",
        	            	      "version": "0.0.1"
        	            	    },
        	            	    "name": "ibmcloud-kube-audit",
        	            	    "namespace": "default",
        	            	    "pass_credentials": false,
        	            	    "postrender": "SECURE_VALUE_HIDDEN_HASH:-ec1660da6cbb3fce015fe7a4e0facd09a8ac9ee1ca147e2d420c7870",
        	            	    "recreate_pods": true,
        	            	    "render_subchart_notes": true,
        	            	    "replace": false,
        	            	    "repository": null,
        	            	    "repository_ca_file": null,
        	            	    "repository_cert_file": null,
        	            	    "repository_key_file": null,
        	            	    "repository_password": "SECURE_VALUE_HIDDEN_HASH:-82ea4dc2bf12e521a8cb73c1cdf3a9189673667862a572bd4b11ebcb",
        	            	    "repository_username": null,
        	            	    "reset_values": false,
        	            	    "reuse_values": false,
        	            	    "set": "SECURE_VALUE_HIDDEN_HASH:-91655f43e320de9c7f276da1036ed0149ccc9b28bffc2c4818dcb4c4",
        	            	    "set_list": "SECURE_VALUE_HIDDEN_HASH:-14b3ded2e777911e1b3bb60bac27214398f6229fa5f39be8a12f02bc",
        	            	    "set_sensitive": "SECURE_VALUE_HIDDEN_HASH:-33ffd0c0d9b65aac3a5e8fd61c2e7c95d935fc5abf5329ebe9ef8008",
        	            	    "set_wo": null,
        	            	    "set_wo_revision": 1,
        	            	    "skip_crds": false,
        	            	    "status": "deployed",
        	            	    "timeout": 1200,
        	            	    "values": null,
        	            	    "verify": false,
        	            	    "version": "0.0.1",
        	            	    "wait": true,
        	            	    "wait_for_jobs": false
        	            	  },
        	            	  "before_identity": {
        	            	    "namespace": "default",
        	            	    "release_name": "ibmcloud-kube-audit"
        	            	  },
        	            	  "before_sensitive": {
        	            	    "metadata": {},
        	            	    "postrender": {
        	            	      "args": []
        	            	    },
        	            	    "repository_password": true,
        	            	    "set": [
        	            	      {},
        	            	      {},
        	            	      {},
        	            	      {}
        	            	    ],
        	            	    "set_list": [],
        	            	    "set_sensitive": []
        	            	  }
        	            	}

@kierramarie
Copy link
Member Author 

         2025/09/05 15:32:44 Terraform plan |   # module.kube_audit[0].helm_release.kube_audit will be updated in-place
         2025/09/05 15:32:44 Terraform plan |   ~ resource "helm_release" "kube_audit" {
         2025/09/05 15:32:44 Terraform plan |       ~ id                         = "ibmcloud-kube-audit" -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |       ~ metadata                   = {
         2025/09/05 15:32:44 Terraform plan |           ~ app_version    = "1.0.0" -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |           ~ chart          = "kube-audit" -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |           ~ first_deployed = 1757085915 -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |           ~ last_deployed  = 1757085915 -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |           ~ name           = "ibmcloud-kube-audit" -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |           ~ namespace      = "default" -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |           + notes          = (known after apply)
         2025/09/05 15:32:44 Terraform plan |           ~ revision       = 1 -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |           ~ values         = jsonencode({}) -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |           ~ version        = "0.0.1" -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |         } -> (known after apply)
         2025/09/05 15:32:44 Terraform plan |         name                       = "ibmcloud-kube-audit"
         2025/09/05 15:32:44 Terraform plan |       - postrender                 = {
         2025/09/05 15:32:44 Terraform plan |           - args        = [] -> null
         2025/09/05 15:32:44 Terraform plan |           - binary_path = "" -> null
         2025/09/05 15:32:44 Terraform plan |         } -> null
         2025/09/05 15:32:44 Terraform plan |       ~ set                        = [
         2025/09/05 15:32:44 Terraform plan |           ~ {
         2025/09/05 15:32:44 Terraform plan |               ~ name  = "image.name" -> "metadata.name"
         2025/09/05 15:32:44 Terraform plan |               ~ value = "icr.io/ibm/ibmcloud-kube-audit-to-ibm-cloud-logs" -> "ibmcloud-kube-audit"
         2025/09/05 15:32:44 Terraform plan |                 # (1 unchanged attribute hidden)
         2025/09/05 15:32:44 Terraform plan |             },
         2025/09/05 15:32:44 Terraform plan |           ~ {
         2025/09/05 15:32:44 Terraform plan |               ~ name  = "image.tag" -> "metadata.namespace"
         2025/09/05 15:32:44 Terraform plan |               ~ value = *image tag* -> "ibm-kube-audit"
         2025/09/05 15:32:44 Terraform plan |                 # (1 unchanged attribute hidden)
         2025/09/05 15:32:44 Terraform plan |             },
         2025/09/05 15:32:44 Terraform plan |           ~ {
         2025/09/05 15:32:44 Terraform plan |               ~ name  = "metadata.name" -> "image.name"
         2025/09/05 15:32:44 Terraform plan |               ~ value = "ibmcloud-kube-audit" -> "icr.io/ibm/ibmcloud-kube-audit-to-ibm-cloud-logs"
         2025/09/05 15:32:44 Terraform plan |                 # (1 unchanged attribute hidden)
         2025/09/05 15:32:44 Terraform plan |             },
         2025/09/05 15:32:44 Terraform plan |           ~ {
         2025/09/05 15:32:44 Terraform plan |               ~ name  = "metadata.namespace" -> "image.tag"
         2025/09/05 15:32:44 Terraform plan |               ~ value = "ibm-kube-audit" -> *image tag*
         2025/09/05 15:32:44 Terraform plan |                 # (1 unchanged attribute hidden)
         2025/09/05 15:32:44 Terraform plan |             },
         2025/09/05 15:32:44 Terraform plan |         ]
         2025/09/05 15:32:44 Terraform plan |       - set_list                   = [] -> null
         2025/09/05 15:32:44 Terraform plan |       - set_sensitive              = [] -> null
         2025/09/05 15:32:44 Terraform plan |       - set_wo_revision            = 1 -> null
         2025/09/05 15:32:44 Terraform plan |         # (26 unchanged attributes hidden)
         2025/09/05 15:32:44 Terraform plan |     }

@kierramarie
Copy link
Member Author

It seems the only thing changed is the helm release, causing an update in place.

ocofaigh
ocofaigh requested changes Sep 6, 2025
View reviewed changes
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kierramarie module.kube_audit[0].helm_release.kube_audit needs to be added to the Ignore update list in the tests

@ocofaigh
Copy link
Contributor

@kierramarie Any update?

@kierramarie
Copy link
Member Author

/run pipeline

@ocofaigh ocofaigh merged commit ab7ed6f into main Sep 11, 2025
2 checks passed
@ocofaigh ocofaigh deleted the ks-helmv3 branch September 11, 2025 15:43
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.59.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@toddgiguere toddgiguere Awaiting requested review from toddgiguere toddgiguere is a code owner

@Aashiq-J Aashiq-J Awaiting requested review from Aashiq-J Aashiq-J is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kierramarie @ocofaigh @terraform-ibm-modules-ops