Skip to content

Conversation

@mukulpalit-ibm
Copy link
Contributor

@mukulpalit-ibm mukulpalit-ibm commented Sep 22, 2025

Description

  • Resolving issues with landing zone deployable architecture

Issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content
  • Fixed sample HCL value for additional worker pools
  • Added learn more for default_worker_pool_labels
  • Added HCL editor for subnets
  • Changed default value for SM plan to standard
  • Updated public_gateway for subnets
  • Marked auto-wired and complex inputs as hidden

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

1 similar comment
@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

Copy link
Member

@maheshwarishikha maheshwarishikha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the default value of subnet as discussed. Rest all looks fine.

@mukulpalit-ibm
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit f679d9d into main Sep 26, 2025
2 checks passed
@ocofaigh ocofaigh deleted the 16016-part3-changes branch September 26, 2025 08:26
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.62.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ocofaigh
Copy link
Contributor

ocofaigh commented Oct 2, 2025

@maheshwarishikha We need to do a better job at the release notes:
image

They are missing many things that came in this PR. And also they don't specify what variation these were made in.

@maheshwarishikha
Copy link
Member

@maheshwarishikha We need to do a better job at the release notes: image

They are missing many things that came in this PR. And also they don't specify what variation these were made in.

Noted. Will work towards it. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants