-
Notifications
You must be signed in to change notification settings - Fork 13
feat: add variable to skip resetting api key #828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
/run pipeline |
1 similar comment
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments. I'm not sure about hiding it from the fully configurable DA. Otherwise how is the consumer supposed to use it?
variables.tf
Outdated
| default = false | ||
| } | ||
|
|
||
| variable "skip_api_key_reset" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should call this a reset. In our module its always going to create one. So we should name this skip_cluster_apikey_creation
variables.tf
Outdated
|
|
||
| variable "skip_api_key_reset" { | ||
| type = bool | ||
| description = "To skip resetting the `containers-kubernetes-key` for the given region and resource group." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set to true to skip explicit creation of the containers-kubernetes-key for the given region and resource group. You can set this to false if you plan to manually create this key, or if you want to allow the cluster creation process to create it. Please be aware that it may take multiple apply attempts when allowing the cluster creation process to create it it before it will be successful.
|
/run pipeline |
2 similar comments
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 3.67.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
issue: #827
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers