Skip to content

Conversation

@vbontempi
Copy link
Member

@vbontempi vbontempi commented Oct 23, 2025

Description

removed apikey from terraform_data input structure and moved to triggers_replace

Upgrade tests skipped as change raises an update on the terraform_data.delete_secrets[0] resource to be destroyed and recreated

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

removed apikey from terraform_data input structure and moved to triggers_replace

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@vbontempi
Copy link
Member Author

/run pipeline

@vbontempi vbontempi requested review from ocofaigh and toddgiguere and removed request for Aashiq-J and toddgiguere October 23, 2025 16:03
ocofaigh
ocofaigh previously approved these changes Oct 23, 2025
@vbontempi
Copy link
Member Author

/run pipeline

@ocofaigh
Copy link
Contributor

@vbontempi Why was upgrade test skipped? I see a valid error in the tests:

 2025/10/23 16:19:48 Terraform plan | Error: Invalid value for variable
 2025/10/23 16:19:48 Terraform plan | 
 2025/10/23 16:19:48 Terraform plan |   on schematics.tfvars line 2:
 2025/10/23 16:19:48 Terraform plan |    2: prefix = "3fw3"
 2025/10/23 16:19:48 Terraform plan |     ├────────────────
 2025/10/23 16:19:48 Terraform plan |     │ var.prefix is "3fw3"

@ocofaigh ocofaigh merged commit ddd568a into main Oct 24, 2025
@ocofaigh ocofaigh deleted the fix_apikey_exposure branch October 24, 2025 08:19
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.66.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants