-
Notifications
You must be signed in to change notification settings - Fork 15
fix: update OCP landing zone UI validations and field configurations #862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ss and outbound traffic
…_zone and changes prefix to openshift across all flavours
… with custom_config pattern"
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
|
LGTM |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Aashiq-J
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/run pipeline |
|
On second thought, if allow_public_access_to_cluster_management is set to false, the cluster will be private. In that case, there's no reason to display the "Open Web Console" button, since it won’t be accessible from the public internet. |
|
@Aashiq-J You could access it if you had a client to site VPN on your machine. Also the IKS Dashboard shows the button even if you don't have access, so its just the same. |
|
/run pipeline |
|
Skipping upgrade tests for this PR. |
|
/run pipeline |
|
@HarikaPonna When skipping the upgrade test, please include the snippet from the logs that shows the upgrade test failure reason. I can see this was actually the failure in the last run before upgrade test was skipped: However I can see the run before that, the following (which as you said is expected): |
|
Re-running the pipeline. The apply phase completed successfully — verified in the Schematics logs. The destroy phase failed due to a timeout error |
|
/run pipeline |
|
@HarikaPonna Can we make sure we are consistent in the other variations too. The source code is in https://github.com/terraform-ibm-modules/terraform-ibm-landing-zone |
|
🎉 This PR is included in version 3.72.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Yes, I’ve updated the other variations as well. |


Description
Addresses multiple UI-related issues in the OCP Landing Zone DA, including:
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
updated OCP landing zone UI validations and field configurations
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers