feat: Monolith example for base-ocp-vpc DA #883
+4,799
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/run pipeline |
1 similar comment
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
1 similar comment
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
vkuma17
reviewed
Dec 5, 2025
vkuma17
requested changes
Dec 5, 2025
Contributor
vkuma17
left a comment
vkuma17
left a comment
There was a problem hiding this comment.
looks good overall, just have some suggestions related to observability
Contributor
Author
|
/run pipeline |
vkuma17
previously approved these changes
Dec 9, 2025
vburckhardt
requested changes
Dec 9, 2025
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
1 similar comment
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
Contributor
Author
|
/run pipeline |
vburckhardt
requested changes
Dec 11, 2025
Comment on lines
1
to
9
| # IBM Cloud OpenShift DA - Monolith Add-ons Module Example | ||
|
|
||
| A simple example that shows how to provision a multi zone OCP VPC cluster as well as all foundational infrastructure and supporting services required for a secure and compliant OpenShift (OCP) cluster deployment on IBM Cloud VPC. | ||
|
|
||
| - Refer [here](../../modules/containerized_app_landing_zone/README.md) to check all the resources are provisioned by this example by calling the monolith module. | ||
| - A new resource group if an existing resource group is not passed. | ||
| - Monitoring agent. | ||
| - A Trusted Profile with Sender role to logs service. | ||
| - Logs agent. |
Member
There was a problem hiding this comment.
Title and content wherever monolith is used - need to update.
Please add details in points.
Contributor
Author
There was a problem hiding this comment.
title and monolith usage updated. The details here removed earlier with the reference link to the read of module as per Vincent's comment #883 (comment)
Contributor
Author
|
/run pipeline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR adds a new module for monolith. This module integrates essential foundational services for security, monitoring, and logging for creating a fully configurable OCP cluster on an IBM Cloud Virtual Private Cloud. The example is added to other_tests.go
Test passed in schematics
Release required?
Adding a plain monolith example of base-ocp-vpc DA deployment by creating the add ons using terraform code.
x.x.X)x.X.x)X.x.x)Release notes content
Adding a new
monolithmodule that creates all the configurations and resources that are created in the EPX UI by selecting the add-ons. It is called in a new example that also createsmonitoring and logs agentafter the OCP cluster is readyRun the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers