Skip to content

Conversation

@Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented May 21, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J Aashiq-J requested a review from toddgiguere as a code owner May 21, 2025 02:40
@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

@Aashiq-J
Copy link
Member Author

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toddgiguere Im ok with this approach - any concerns?

@toddgiguere
Copy link
Member

toddgiguere commented May 29, 2025

This looks good to me, in fact I think it is a very good improvement over the old method. In the old method if the "version" was null then that meant you didn't want to install, and also meant you had to supply a version for ones you do want.

I just verified, according to documentation:

version- (Optional, String) The add-on version. Omit the version that you want to use as the default version.This is required when you want to update the add-on to specified version.

So with this new solution, someone could make the "object" not null, but keep "version" null, which will use default version. A bit more flexible I think.

I do wish we could get rid of the csi driver though.

@ocofaigh ocofaigh merged commit 732f2bb into main May 29, 2025
2 checks passed
@ocofaigh ocofaigh deleted the add branch May 29, 2025 18:04
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 3.49.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants