diff --git a/.secrets.baseline b/.secrets.baseline index 8905b89e..cbd24bf5 100644 --- a/.secrets.baseline +++ b/.secrets.baseline @@ -3,7 +3,7 @@ "files": "go.sum|^.secrets.baseline$", "lines": null }, - "generated_at": "2025-09-05T15:37:15Z", + "generated_at": "2025-09-29T09:18:41Z", "plugins_used": [ { "name": "AWSKeyDetector" @@ -82,7 +82,7 @@ "hashed_secret": "8196b86ede820e665b2b8af9c648f4996be99838", "is_secret": false, "is_verified": false, - "line_number": 91, + "line_number": 90, "type": "Secret Keyword", "verified_result": null } diff --git a/tests/pr_test.go b/tests/pr_test.go index 0a4ae415..ae43d110 100644 --- a/tests/pr_test.go +++ b/tests/pr_test.go @@ -8,7 +8,6 @@ import ( "strings" "testing" - "github.com/IBM/go-sdk-core/core" "github.com/gruntwork-io/terratest/modules/files" "github.com/gruntwork-io/terratest/modules/logger" "github.com/gruntwork-io/terratest/modules/random" @@ -270,23 +269,6 @@ func TestRoksAddonDefaultConfiguration(t *testing.T) { }, ) - /* - Secrets manager is manually disabled in this test because it deploys Event notification - and event notifications DA creates kms keys and during undeploy the order of key protect and event notifications - is not considered by projects as EN is not a direct dependency of OCP DA. So undeploy fails, because - key protect instance can't be deleted because of active keys created by EN. Hence for now, we don't want to deploy - EN so SM is being disabled. - Issue has been created for projects team. https://github.ibm.com/epx/projects/issues/4750 - Once that is fixed, we can remove the logic to disable SM - */ - options.AddonConfig.Dependencies = []cloudinfo.AddonConfig{ - { - OfferingName: "deploy-arch-ibm-secrets-manager", - OfferingFlavor: "fully-configurable", - Enabled: core.BoolPtr(false), // explicitly disabled - }, - } - err := options.RunAddonTest() require.NoError(t, err) }