fix: default DA to public provider visibility as temp workaround for IBM-Cloud/terraform-provider-ibm#5977 (#160)

Author: ocofaigh

solutions/fully-configurable/variables.tf

@@ -44,7 +44,7 @@ variable "prefix" {
 variable "provider_visibility" {
   type        = string
   description = "Set the visibility value for the IBM terraform provider. Supported values are `public`, `private`, `public-and-private`. [Learn more](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/guides/custom-service-endpoints)."
-  default     = "private"
+  default     = "public" # use public as temp workaround for https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5977
 
   validation {
     condition     = contains(["public", "private", "public-and-private"], var.provider_visibility)

solutions/security-enforced/main.tf

@@ -3,7 +3,7 @@ module "security_enforced" {
   ibmcloud_api_key                       = var.ibmcloud_api_key
   ibmcloud_kms_api_key                   = var.ibmcloud_kms_api_key
   ibmcloud_cos_api_key                   = var.ibmcloud_cos_api_key
-  provider_visibility                    = "private"
+  provider_visibility                    = "public" # use public as temp workaround for https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5977
   prefix                                 = var.prefix
   region                                 = var.region
   existing_resource_group_name           = var.existing_resource_group_name