Fully Configurable DA #22

iamar7 · 2025-04-23T10:10:53Z

Description

Solutions for full-configurable have been added along with tests and documentation.

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

iamar7 · 2025-04-23T17:33:16Z

/run pipeline

iamar7 · 2025-04-23T17:48:40Z

/run pipeline

iamar7 · 2025-04-23T20:47:44Z

/run pipeline

iamar7 · 2025-04-24T19:56:34Z

We can have an initial review of the implementation but the CBR support needs to be added in the fully configurable DA which is being tracked in this PR before merge.

ocofaigh · 2025-04-25T08:22:44Z

@iamar7 CBR PR just merged to the module

ocofaigh

See comments

ocofaigh · 2025-04-25T09:48:25Z

tests/pr_test.go

 		assert.NotNil(t, output, "Expected some output")
 	}
 }
+


DA needs an upgrade test too

ocofaigh · 2025-04-25T09:49:30Z

solutions/fully-configurable/variables.tf

+variable "provider_visibility" {
+  description = "Set the visibility value for the IBM terraform provider. Supported values are `public`, `private`, `public-and-private`. [Learn more](https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/guides/custom-service-endpoints)."
+  type        = string
+  default     = "public"


why is this not private?

ocofaigh · 2025-04-25T09:52:02Z

.catalog-onboard-pipeline.yaml

+  - name: deploy-arch-ibm-cloud-monitoring
+    kind: solution
+    catalog_id: xxxx-xxxx-xxxx-xxxx-xxxxxxxx
+    offering_id: xxxx-xxxx-xxxx-xxxx-xxxxxxxx


73debdbf-894f-4c14-81c7-5ece3a70b67d

ocofaigh · 2025-04-25T09:52:08Z

.catalog-onboard-pipeline.yaml

+offerings:
+  - name: deploy-arch-ibm-cloud-monitoring
+    kind: solution
+    catalog_id: xxxx-xxxx-xxxx-xxxx-xxxxxxxx


7df1e4ca-d54c-4fd0-82ce-3d13247308cd

ocofaigh · 2025-04-25T09:53:26Z

solutions/fully-configurable/main.tf

+  create_cloud_monitoring        = var.existing_cloud_monitoring_crn == null
+  cloud_monitoring_crn           = local.create_cloud_monitoring ? module.cloud_monitoring[0].crn : var.existing_cloud_monitoring_crn
+  cloud_monitoring_instance_name = "${local.prefix}${var.cloud_monitoring_instance_name}"
+  metrics_router_target_name     = "${local.prefix}-${var.metrics_routing_target_name}"


I think this will result in a double dash?

ibm_catalog.json

ocofaigh · 2025-04-25T09:54:38Z

ibm_catalog.json

+                            }
+                        },
+                        {
+                            "key": "enable_platform_metrics"


mark this as required

…erraform-ibm-cloud-monitoring into 12594-fc

…form-ibm-cloud-monitoring into 12594-fc

iamar7 · 2025-04-25T12:36:09Z

/run pipeline

ocofaigh · 2025-04-25T13:07:07Z

solutions/fully-configurable/variables.tf

+      }))
+    })))
+  }))
+  description = "(Optional, list) List of context-based restrictions rules to create"


This needs to point to the markdown helper doc

Going to merge the PR as is and we can add this in a subsequent PR. Tracked in #26

ocofaigh · 2025-04-28T11:34:28Z

/run pipeline

ocofaigh · 2025-04-28T14:26:26Z

The test failed on destroy:

 2025/04/28 12:12:06 Terraform destroy | Error: ---
 2025/04/28 12:12:06 Terraform destroy | id: terraform-72679afc
 2025/04/28 12:12:06 Terraform destroy | summary: 'DeleteZoneWithContext failed: The network zone ''38e644d62da87a3b159f89312cbc737f''
 2025/04/28 12:12:06 Terraform destroy |   is referenced by one or more rules and cannot be deleted.'
 2025/04/28 12:12:06 Terraform destroy | severity: error
 2025/04/28 12:12:06 Terraform destroy | resource: ibm_cbr_zone
 2025/04/28 12:12:06 Terraform destroy | operation: delete
 2025/04/28 12:12:06 Terraform destroy | component:
 2025/04/28 12:12:06 Terraform destroy |   name: github.com/IBM-Cloud/terraform-provider-ibm
 2025/04/28 12:12:06 Terraform destroy |   version: 1.77.1
 2025/04/28 12:12:06 Terraform destroy | ---

Seems related to CBR zone and not code in the module. Will retry..

ocofaigh · 2025-04-28T14:26:31Z

/run pipeline

terraform-ibm-modules-ops · 2025-04-28T15:49:14Z

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

GitHub release
v1.2.0

Your semantic-release bot 📦🚀

fully configurable DA

50d51f5

iamar7 self-assigned this Apr 23, 2025

Md Anam Raihan added 3 commits April 23, 2025 16:46

update fully configurable DA

d17d803

update fully configurable DA

5b25a59

update test

b0a6471

resolve pre-commit error

f0e2d34

update tests

c5b3f5e

iamar7 marked this pull request as ready for review April 24, 2025 16:19

iamar7 requested a review from shemau as a code owner April 24, 2025 16:19

ocofaigh requested changes Apr 25, 2025

View reviewed changes

Md Anam Raihan and others added 5 commits April 25, 2025 17:57

resolve comments

f591661

Merge branch '12594-fc' of https://github.com/terraform-ibm-modules/t…

091dff7

…erraform-ibm-cloud-monitoring into 12594-fc

Merge branch 'main' of https://github.com/terraform-ibm-modules/terra…

723fb87

…form-ibm-cloud-monitoring into 12594-fc

add cbr rule and SKIP UPGRADE TEST

f2961c4

update ibm_catalog

3cdc19a

ocofaigh reviewed Apr 25, 2025

View reviewed changes

Merge branch 'main' into 12594-fc

56de8b4

ocofaigh mentioned this pull request Apr 28, 2025

Add markdown helper doc for Cloud Monitoring DA CBR input #26

Closed

ocofaigh approved these changes Apr 28, 2025

View reviewed changes

ocofaigh merged commit 19115cb into main Apr 28, 2025
2 checks passed

ocofaigh deleted the 12594-fc branch April 28, 2025 15:48

terraform-ibm-modules-ops added the released label Apr 28, 2025

Fully Configurable DA #22

Fully Configurable DA #22

Uh oh!

Conversation

iamar7 commented Apr 23, 2025

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

Uh oh!

iamar7 commented Apr 23, 2025

Uh oh!

iamar7 commented Apr 23, 2025

Uh oh!

iamar7 commented Apr 23, 2025

Uh oh!

iamar7 commented Apr 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ocofaigh commented Apr 25, 2025

Uh oh!

ocofaigh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

iamar7 commented Apr 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ocofaigh commented Apr 28, 2025

Uh oh!

ocofaigh commented Apr 28, 2025

Uh oh!

ocofaigh commented Apr 28, 2025

Uh oh!

Uh oh!

terraform-ibm-modules-ops commented Apr 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

iamar7 commented Apr 24, 2025 •

edited

Loading