Skip to content

Conversation

@iamar7
Copy link
Member

@iamar7 iamar7 commented May 5, 2025

Description

Removing the metrics router setting part from the advanced example as it is causing intermittent pipeline failure.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7
Copy link
Member Author

iamar7 commented May 5, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented May 5, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented May 5, 2025

Was getting this failure so removed multiple random string from prefix.

Screenshot 2025-05-05 at 7 30 48 PM

@iamar7
Copy link
Member Author

iamar7 commented May 5, 2025

/run pipeline

@iamar7 iamar7 self-assigned this May 5, 2025
@iamar7
Copy link
Member Author

iamar7 commented May 5, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented May 5, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented May 6, 2025

Need to skip the upgrade test as while running the Upgrade test it switches to main branch where prefix length is more than 16 in every case.

tests.go:100: [SCHEMATICS] Creating Test Workspace
    tests.go:106: [SCHEMATICS] Workspace Created: icm-da-upg-yr0sy1 (eu-de.workspace.icm-da-upg-yr0sy1.59556702)
    tests.go:114: [SCHEMATICS] Switching to target (main) code for UPGRADE TEST
    tests.go:528: [SCHEMATICS] TEMP UPGRADE BASE DIR CREATED:  /var/folders/0_/854wrs610sqctnttj4y_yz1r0000gn/T/terraform-base-icm-da-upg-yr0sy12743690174
TestRunUpgradeFullyConfigurable 2025-05-06T12:10:53+05:30 git.go:500: Cloned base repo and branch with authentication
    schematics.go:233: [SCHEMATICS] Creating TAR file
    schematics.go:239: [SCHEMATICS] Uploading TAR file
    schematics.go:557: [SCHEMATICS] ... still waiting for job TAR_WORKSPACE_UPLOAD to complete: 1 minutes
    schematics.go:566: [SCHEMATICS] The status of job TAR_WORKSPACE_UPLOAD is: COMPLETED
    tests.go:136: [SCHEMATICS] Updating Workspace Variablestore
    tests.go:152: [SCHEMATICS] Starting PLAN job ...
    schematics.go:557: [SCHEMATICS] ... still waiting for job PLAN to complete: 1 minutes
    schematics.go:557: [SCHEMATICS] ... still waiting for job PLAN to complete: 2 minutes
    schematics.go:566: [SCHEMATICS] The status of job PLAN is: FAILED

@iamar7
Copy link
Member Author

iamar7 commented May 6, 2025

/run pipeline

@iamar7 iamar7 marked this pull request as ready for review May 6, 2025 09:16
@iamar7 iamar7 requested a review from shemau as a code owner May 6, 2025 09:16
@maheshwarishikha
Copy link
Member

@iamar7 can we check upgrade test with prefix as null?
As this change is only in examples and test, then no release is required.

@iamar7
Copy link
Member Author

iamar7 commented May 7, 2025

@iamar7 can we check upgrade test with prefix as null? As this change is only in examples and test, then no release is required.

I have tested locally with prefix as null it is working fine. In the test, I have reduced the length so that it doesn't fail in the pipeline. Also, I have updated the PR template to no release.

@maheshwarishikha maheshwarishikha merged commit cc4ab0f into main May 7, 2025
2 checks passed
@maheshwarishikha maheshwarishikha deleted the 12223-mr branch May 7, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants