-
Notifications
You must be signed in to change notification settings - Fork 1
docs: add markdown helper doc for Cloud Monitoring DA CBR input #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
Failed due to prefix exceeding the length |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
ocofaigh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 comment
tests/pr_test.go
Outdated
|
|
||
| var region = validRegions[rand.Intn(len(validRegions))] | ||
| prefix := fmt.Sprintf("icm-da-up-%s", strings.ToLower(random.UniqueId())) | ||
| prefix := "icm-da-up-" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change this back and then update line 140 to use the prefix (instead of options.Prefix)
|
/run pipeline |
Description
Add markdown helper doc for Cloud Monitoring DA CBR input
Resolves: #26
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers