Skip to content

Conversation

@iamar7
Copy link
Member

@iamar7 iamar7 commented May 5, 2025

Description

Add markdown helper doc for Cloud Monitoring DA CBR input

Resolves: #26

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@iamar7
Copy link
Member Author

iamar7 commented May 5, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented May 5, 2025

Failed due to prefix exceeding the length

 2025/05/05 16:02:45 Terraform plan | Error: Invalid value for variable
         2025/05/05 16:02:45 Terraform plan | 
         2025/05/05 16:02:45 Terraform plan |   on schematics.tfvars line 6:
         2025/05/05 16:02:45 Terraform plan |    6: prefix = "icm-da-upg-c7xxe4-vco7wu"
         2025/05/05 16:02:45 Terraform plan |     ├────────────────
         2025/05/05 16:02:45 Terraform plan |     │ var.prefix is "icm-da-upg-c7xxe4-vco7wu"
         2025/05/05 16:02:45 Terraform plan | 
         2025/05/05 16:02:45 Terraform plan | Prefix must begin with a lowercase letter, contain only lowercase letters,
         2025/05/05 16:02:45 Terraform plan | numbers, and - characters. Prefixes must end with a lowercase letter or
         2025/05/05 16:02:45 Terraform plan | number and be 16 or fewer characters.
         2025/05/05 16:02:45 Terraform plan | 
         2025/05/05 16:02:45 Terraform plan | This was checked by the validation rule at variables.tf:21,3-13.

@iamar7 iamar7 self-assigned this May 6, 2025
@iamar7 iamar7 marked this pull request as ready for review May 6, 2025 12:18
@iamar7 iamar7 requested a review from shemau as a code owner May 6, 2025 12:18
@iamar7
Copy link
Member Author

iamar7 commented May 7, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented May 8, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented May 8, 2025

/run pipeline

@iamar7 iamar7 requested review from Ak-sky and ocofaigh May 8, 2025 09:34
@iamar7
Copy link
Member Author

iamar7 commented May 8, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented May 9, 2025

/run pipeline

@iamar7
Copy link
Member Author

iamar7 commented May 9, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comment

tests/pr_test.go Outdated

var region = validRegions[rand.Intn(len(validRegions))]
prefix := fmt.Sprintf("icm-da-up-%s", strings.ToLower(random.UniqueId()))
prefix := "icm-da-up-"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change this back and then update line 140 to use the prefix (instead of options.Prefix)

@iamar7
Copy link
Member Author

iamar7 commented May 9, 2025

/run pipeline

@ocofaigh ocofaigh merged commit 583fc82 into main May 10, 2025
2 checks passed
@ocofaigh ocofaigh deleted the 13571-doc branch May 10, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add markdown helper doc for Cloud Monitoring DA CBR input

3 participants