support graduated-tier-sysdig-secure-plus-monitor plan #61
Conversation
|
/run pipeline |
| prefix := "icm-da" | ||
| plan := "lite" | ||
|
|
||
| // when region is 'eu-fr2' take opportunity to test 'graduated-tier-sysdig-secure-plus-monitor' plan |
There was a problem hiding this comment.
not sure this will work since eu-fr2' is not inside validRegions
terraform-ibm-cloud-monitoring/tests/pr_test.go
Lines 26 to 36 in c32c505
There was a problem hiding this comment.
@akocbek hmmmm.. do you know is there a reason eu-fr2 isnt in validRegions? We should be good to just add it to the list shouldn't we?
There was a problem hiding this comment.
tested that er-fr2 works so I guess should be good to go in the validRegions list
There was a problem hiding this comment.
added to it should be fine, actually we should have all valid regions inside array.
https://cloud.ibm.com/docs/monitoring?topic=monitoring-regions
|
/run pipeline |
| prefix := "icm-da" | ||
| plan := "lite" | ||
|
|
||
| // when region is 'eu-fr2' take opportunity to test 'graduated-tier-sysdig-secure-plus-monitor' plan |
There was a problem hiding this comment.
added to it should be fine, actually we should have all valid regions inside array.
https://cloud.ibm.com/docs/monitoring?topic=monitoring-regions
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
for issue https://github.ibm.com/GoldenEye/issues/issues/14657
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers