Skip to content

Conversation

@arya-girish-k
Copy link
Contributor

Description

Added Ignore addresses in the tests

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh changed the title fix: Added Ignore addresses in the tests test: Added Ignore addresses in the tests Jul 25, 2025
Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just create 2 global variables in por_test.go instead of duplicating the code everywhere?

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit 1447988 into main Jul 25, 2025
2 checks passed
@ocofaigh ocofaigh deleted the ignorelist branch July 25, 2025 10:31
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants