-
Notifications
You must be signed in to change notification settings - Fork 1
fix(deps): update DA dependencies + cleanup tests #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
|
/run pipeline |
|
Hmm, got an odd error with CRA: Going to retry once.. |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we removing TestDependencyPermutations from the test?
examples/advanced/README.md
Outdated
| - A context-based restriction (CBR) zone for the IBM Cloud Schematics service. | ||
| - An IBM Cloud Monitoring instance. | ||
| - A context-based restriction (CBR) rule to only allow the Cloud Monitoring to be accessible from the Schematics zone. | ||
| - A Metrics Routing target for the new IBM Cloud Monitoring instance and a route to route send metrics to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - A Metrics Routing target for the new IBM Cloud Monitoring instance and a route to route send metrics to it. | |
| - A Metrics Routing target for the new IBM Cloud Monitoring instance and a route to send metrics to it. |
|
Failed again with the same error: |
|
I think we need to set |
|
@iamar7 No the DA supports using |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
🎉 This PR is included in version 1.7.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
v3.0.23in add-ons configRelease required?
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers