Skip to content

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Sep 15, 2025

Description

  • updated Account config DA to v3.0.23 in add-ons config
  • examples and tests cleanup
  • updated CRA config to scan the DA

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

Hmm, got an odd error with CRA:

Error: [0m Error: [ERROR] Error occured while fetching account user details: "token is malformed: token contains an invalid number of segments"
│ 
│   with module.resource_group.data.ibm_resource_group.default[0],
│   on .terraform/modules/resource_group/main.tf line 14, in data "ibm_resource_group" "default":
│   14: data "ibm_resource_group" "default" {
│ 
│ ---
│ id: terraform-76ac39fe
Error: [0m summary: '[ERROR] Error occured while fetching account user details: "token
│ is malformed:
│   token contains an invalid number of segments"'
│ severity: error
│ resource: (Data) ibm_resource_group
│ operation: read
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.82.1
│ ---

Going to retry once..

@ocofaigh
Copy link
Contributor Author

/run pipeline

Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we removing TestDependencyPermutations from the test?

- A context-based restriction (CBR) zone for the IBM Cloud Schematics service.
- An IBM Cloud Monitoring instance.
- A context-based restriction (CBR) rule to only allow the Cloud Monitoring to be accessible from the Schematics zone.
- A Metrics Routing target for the new IBM Cloud Monitoring instance and a route to route send metrics to it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- A Metrics Routing target for the new IBM Cloud Monitoring instance and a route to route send metrics to it.
- A Metrics Routing target for the new IBM Cloud Monitoring instance and a route to send metrics to it.

@iamar7
Copy link
Member

iamar7 commented Sep 16, 2025

Failed again with the same error:

Error: [0m Error: [ERROR] Error occured while fetching account user details: "token is malformed: token contains an invalid number of segments"
│ 
│   with module.resource_group.data.ibm_resource_group.default[0],
│   on .terraform/modules/resource_group/main.tf line 14, in data "ibm_resource_group" "default":
│   14: data "ibm_resource_group" "default" {
│ 
│ ---
│ id: terraform-76ac39fe
Error: [0m summary: '[ERROR] Error occured while fetching account user details: "token
│ is malformed:
│   token contains an invalid number of segments"'
│ severity: error
│ resource: (Data) ibm_resource_group
│ operation: read
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.82.1
│ ---
│ 

@iamar7
Copy link
Member

iamar7 commented Sep 16, 2025

I think we need to set existing_resource_group_name in the CRA config as well for the above issue to resolve

@ocofaigh
Copy link
Contributor Author

@iamar7 No the DA supports using null as default and it will lookup the default resource group. The issue was CRA was using private provider.
Yes we are removing permutations test everywhere - we can't run them without getting rate limited.

@ocofaigh
Copy link
Contributor Author

/run pipeline

Copy link
Member

@iamar7 iamar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh ocofaigh merged commit ceae6cc into main Sep 16, 2025
2 checks passed
@ocofaigh ocofaigh deleted the tests branch September 16, 2025 11:01
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants