feat: add support to create resource key #90

iamar7 · 2025-09-16T07:25:29Z

Description

Resolves: #28

Release required?

No release
Patch release (x.x.X)
Minor release (x.X.x)
Major release (X.x.x)

Release notes content

This release added a new disable_access_key_creation flag (default: false) to allow opting out of automatic access key creation and added an additional method to support multiple resource keys. You can now define multiple keys by adding more entries to the resource_keys list.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

If relevant, a test for the change is included or updated with this PR.
If relevant, documentation for the change is included or updated with this PR.

For mergers

Use a conventional commit message to set the release level. Follow the guidelines.
Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
Use the Squash and merge option.

…form-ibm-cloud-monitoring into 12536-key

iamar7 · 2025-09-16T08:33:02Z

/run pipeline

iamar7 · 2025-09-18T14:02:25Z

/run pipeline

iamar7 · 2025-09-18T16:49:40Z

/run pipeline

iamar7 · 2025-09-19T03:43:41Z

The TestAddonDefaultConfiguration failed with the following error:

	(icm-def-paw-deploy-arch-ibm-cloud-monitoring) Deployment error:
Error: ge: [ERROR] Error deleting resource instance: The broker for 'Cloud Monitoring' service returned error, [400, Bad Request] Sysdig instance update request return code: 400 message: 400 BAD_REQUEST. If this is unexpected, open a support ticket with the service to help troubleshoot the issue. with resp code: {
		resource_type: ibm_resource_group.default[0]
[TestAddonDefaultConfiguration]   undeploy stack failed with state undeploying_failed
[TestAddonDefaultConfiguration] === END BUFFERED LOG OUTPUT ===
[TestAddonDefaultConfiguration] 🔄 Cleaning up resources
[TestAddonDefaultConfiguration] TEST EXECUTION END: TestAddonDefaultConfiguration - RESULT: PASSED
=== NAME  TestAddonDefaultConfiguration
    pr_test.go:246: 
        	Error Trace:	/__w/terraform-ibm-cloud-monitoring/terraform-ibm-cloud-monitoring/tests/pr_test.go:246
        	Error:      	Received unexpected error:
        	            	errors occurred during undeploy
        	Test:       	TestAddonDefaultConfiguration
--- FAIL: TestAddonDefaultConfiguration (569.10s)

Re-running the pipeline

iamar7 · 2025-09-19T03:44:25Z

/run pipeline

iamar7 · 2025-09-19T07:56:18Z

Failing due to the earlier resource key being destroyed

2025/09/19 03:59:25 Terraform plan | Terraform used the selected providers to generate the following execution
      2025/09/19 03:59:25 Terraform plan | plan. Resource actions are indicated with the following symbols:
      2025/09/19 03:59:25 Terraform plan |   - destroy
      2025/09/19 03:59:25 Terraform plan | 
      2025/09/19 03:59:25 Terraform plan | Terraform will perform the following actions:
      2025/09/19 03:59:25 Terraform plan | 
      2025/09/19 03:59:25 Terraform plan |   # module.cloud_monitoring[0].ibm_resource_key.resource_key will be destroyed
      2025/09/19 03:59:25 Terraform plan |   # (because resource uses count or for_each)
      2025/09/19 03:59:25 Terraform plan |   - resource "ibm_resource_key" "resource_key" {
      2025/09/19 03:59:25 Terraform plan |       - account_id            = "abac0df06b644a9cabc6e44f55b3880e" -> null
      2025/09/19 03:59:25 Terraform plan |       - created_at            = "2025-09-19T03:55:28.378Z" -> null
      2025/09/19 03:59:25 Terraform plan |       - created_by            = "IBMid-666000KAO3" -> null
      2025/09/19 03:59:25 Terraform plan |       - credentials           = (sensitive value) -> null
      2025/09/19 03:59:25 Terraform plan |       - credentials_json      = (sensitive value) -> null
      2025/09/19 03:59:25 Terraform plan |       - crn                   = "crn:v1:bluemix:public:sysdig-monitor:us-east:a/abac0df06b644a9cabc6e44f55b3880e:4e194131-d8f6-4f04-b769-991759957e4f:resource-key:347838de-2cc9-483b-9270-99e1d19823d5" -> null
      2025/09/19 03:59:25 Terraform plan |       - guid                  = "347838de-2cc9-483b-9270-99e1d19823d5" -> null
      2025/09/19 03:59:25 Terraform plan |       - iam_compatible        = true -> null
      2025/09/19 03:59:25 Terraform plan |       - id                    = "crn:v1:bluemix:public:sysdig-monitor:us-east:a/abac0df06b644a9cabc6e44f55b3880e:4e194131-d8f6-4f04-b769-991759957e4f:resource-key:347838de-2cc9-483b-9270-99e1d19823d5" -> null
      2025/09/19 03:59:25 Terraform plan |       - name                  = "SysdigManagerKey" -> null
      2025/09/19 03:59:25 Terraform plan |       - onetime_credentials   = false -> null
      2025/09/19 03:59:25 Terraform plan |       - resource_group_id     = "292170bc79c94f5e9019e46fb48f245a" -> null
      2025/09/19 03:59:25 Terraform plan |       - resource_instance_id  = "crn:v1:bluemix:public:sysdig-monitor:us-east:a/abac0df06b644a9cabc6e44f55b3880e:4e194131-d8f6-4f04-b769-991759957e4f::" -> null
      2025/09/19 03:59:25 Terraform plan |       - resource_instance_url = "/v2/resource_instances/4e194131-d8f6-4f04-b769-991759957e4f" -> null
      2025/09/19 03:59:25 Terraform plan |       - role                  = "Manager" -> null
      2025/09/19 03:59:25 Terraform plan |       - source_crn            = "crn:v1:bluemix:public:sysdig-monitor:us-east:a/abac0df06b644a9cabc6e44f55b3880e:4e194131-d8f6-4f04-b769-991759957e4f::" -> null
      2025/09/19 03:59:25 Terraform plan |       - state                 = "active" -> null
      2025/09/19 03:59:25 Terraform plan |       - status                = "active" -> null
      2025/09/19 03:59:25 Terraform plan |       - updated_at            = "2025-09-19T03:55:28.378Z" -> null
      2025/09/19 03:59:25 Terraform plan |       - url                   = "/v2/resource_keys/347838de-2cc9-483b-9270-99e1d19823d5" -> null
      2025/09/19 03:59:25 Terraform plan |         # (3 unchanged attributes hidden)
      2025/09/19 03:59:25 Terraform plan |     }
      2025/09/19 03:59:25 Terraform plan | 
      2025/09/19 03:59:25 Terraform plan | Plan: 0 to add, 0 to change, 1 to destroy.
      2025/09/19 03:59:25 Terraform plan | 
      2025/09/19 03:59:25 Terraform plan | Changes to Outputs:
      2025/09/19 03:59:25 Terraform plan |   ~ cloud_monitoring_access_key = (sensitive value)
      2025/09/19 03:59:25 Command finished successfully.

outputs.tf

…form-ibm-cloud-monitoring into 12536-key

iamar7 · 2025-09-23T12:57:37Z

/run pipeline

iamar7 · 2025-09-24T12:05:55Z

/run pipeline

…terraform-ibm-cloud-monitoring into 12536-key

iamar7 · 2025-09-25T09:13:09Z

/run pipeline

iamar7 · 2025-09-26T14:44:56Z

/run pipeline

ocofaigh

See comments

variables.tf

solutions/fully-configurable/variables.tf

ocofaigh · 2025-10-21T13:50:52Z

main.tf

+
 resource "ibm_resource_key" "resource_key" {
-  name                 = var.manager_key_name
+  count                = var.disable_access_key_creation ? 0 : 1


wont this be a breaking change without a moved block? Why did upgrade test not fail?

No, when I ran locally terraform is understanding that we've added a count around the resource block. I will attach the screenshot here

Are you sure? Usually a moved block is required when we add a count

main.tf

outputs.tf

iamar7 · 2025-10-21T15:05:54Z

/run pipeline

iamar7 · 2025-10-22T12:09:42Z

/run pipeline

iamar7 · 2025-10-22T12:56:01Z

/run pipeline

ocofaigh

final few comments

solutions/fully-configurable/variables.tf

ocofaigh · 2025-10-22T14:54:14Z

main.tf

+
 resource "ibm_resource_key" "resource_key" {
-  name                 = var.manager_key_name
+  count                = var.disable_access_key_creation ? 0 : 1


Are you sure? Usually a moved block is required when we add a count

outputs.tf

variables.tf

iamar7 · 2025-10-23T05:43:29Z

/run pipeline

iamar7 · 2025-10-23T06:00:16Z

ocofaigh · 2025-10-23T09:26:38Z

outputs.tf

  sensitive   = true
 }

-output "manager_key_name" {


We should keep this output, but it should be renamed to access_key_name

I remember that I have renamed this and added it back, somehow it is not in the final push :(

ocofaigh

@iamar7 1 final comment

iamar7 · 2025-10-24T10:55:41Z

/run pipeline

iamar7 · 2025-10-24T11:17:20Z

@iamar7 1 final comment

Resolved

terraform-ibm-modules-ops · 2025-10-24T11:42:25Z

🎉 This PR is included in version 1.10.0 🎉

The release is available on:

GitHub release
v1.10.0

Your semantic-release bot 📦🚀

Md Anam Raihan and others added 4 commits September 16, 2025 11:56

fix: update resource key creation

35ba0cb

Merge branch 'main' of https://github.com/terraform-ibm-modules/terra…

bd4ccf0

…form-ibm-cloud-monitoring into 12536-key

update output

78ad177

update readme

4df2403

add pragma allowlist

07816b3

update cdev

0bdb1dc

Merge branch 'main' into 12536-key

4647240

iamar7 marked this pull request as ready for review September 19, 2025 09:38

iamar7 requested a review from shemau as a code owner September 19, 2025 09:38

ocofaigh reviewed Sep 19, 2025

View reviewed changes

outputs.tf Outdated Show resolved Hide resolved

Md Anam Raihan and others added 4 commits September 23, 2025 17:53

update resource_key default

83a9a20

resolve comments

96c820d

Merge branch 'main' of https://github.com/terraform-ibm-modules/terra…

7e13bc9

…form-ibm-cloud-monitoring into 12536-key

update output

b15ad6a

set default resource key

d264ed8

Md Anam Raihan added 2 commits September 25, 2025 13:55

Merge branch '12536-key' of https://github.com/terraform-ibm-modules/…

441c212

…terraform-ibm-cloud-monitoring into 12536-key

add moved block

986997c

iamar7 requested a review from ocofaigh September 25, 2025 12:11

iamar7 self-assigned this Sep 25, 2025

Merge branch 'main' into 12536-key

08479eb

ocofaigh requested changes Oct 21, 2025

View reviewed changes

Md Anam Raihan added 4 commits October 21, 2025 20:18

resolve comments

92b82c5

resolve comments

31339a2

update output

8e2d1fa

update description

bdf1388

Md Anam Raihan and others added 3 commits October 22, 2025 15:19

remove exposed variables

df2e732

resolve pc

4e461cb

resolve comments

bf5e586

resolve comments

a4d04c4

ocofaigh requested changes Oct 22, 2025

View reviewed changes

Md Anam Raihan and others added 2 commits October 23, 2025 11:07

resolve comments

58577bc

update readme

17dde29

iamar7 requested a review from ocofaigh October 23, 2025 06:05

iamar7 changed the title ~~fix: update method for resource key creation~~ feat: add support to create resource key Oct 23, 2025

ocofaigh reviewed Oct 23, 2025

View reviewed changes

ocofaigh requested changes Oct 23, 2025

View reviewed changes

iamar7 and others added 2 commits October 24, 2025 10:40

resolve comment

ea61469

update output

5280ede

ocofaigh approved these changes Oct 24, 2025

View reviewed changes

ocofaigh merged commit 7c7df61 into main Oct 24, 2025
2 checks passed

ocofaigh deleted the 12536-key branch October 24, 2025 11:41

terraform-ibm-modules-ops added the released label Oct 24, 2025

feat: add support to create resource key #90

feat: add support to create resource key #90

Uh oh!

Conversation

iamar7 commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Release required?

Release notes content

Run the pipeline

Checklist for reviewers

For mergers

Uh oh!

iamar7 commented Sep 16, 2025

Uh oh!

iamar7 commented Sep 18, 2025

Uh oh!

iamar7 commented Sep 18, 2025

Uh oh!

iamar7 commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iamar7 commented Sep 19, 2025

Uh oh!

iamar7 commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

iamar7 commented Sep 23, 2025

Uh oh!

iamar7 commented Sep 24, 2025

Uh oh!

iamar7 commented Sep 25, 2025

Uh oh!

iamar7 commented Sep 26, 2025

Uh oh!

ocofaigh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ocofaigh Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

iamar7 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

ocofaigh Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

iamar7 commented Oct 21, 2025

Uh oh!

iamar7 commented Oct 22, 2025

Uh oh!

iamar7 commented Oct 22, 2025

Uh oh!

ocofaigh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ocofaigh Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

iamar7 commented Oct 23, 2025

Uh oh!

iamar7 commented Oct 23, 2025

Uh oh!

ocofaigh Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

iamar7 Oct 24, 2025

iamar7 commented Sep 16, 2025 •

edited

Loading

iamar7 commented Sep 19, 2025 •

edited

Loading

iamar7 commented Sep 19, 2025 •

edited

Loading