Skip to content

Commit 4115cf3

Browse files
authored
tests: updated fscloud example for CBR rules (#276)
1 parent 9c88fd0 commit 4115cf3

File tree

2 files changed

+29
-31
lines changed

2 files changed

+29
-31
lines changed

examples/fscloud/main.tf

Lines changed: 28 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -129,35 +129,32 @@ module "event_notification" {
129129
cos_instance_id = module.cos.cos_instance_crn
130130
skip_en_cos_auth_policy = false
131131
cos_endpoint = "https://${module.cos.buckets[local.bucket_name].s3_endpoint_private}"
132-
133-
# There is a known issue https://github.com/IBM-Cloud/terraform-provider-ibm/issues/5525 when adding schematics network zone with private endpoint type to the EN CBR rule, causing this example to fail.
134-
135-
# cbr_rules = [
136-
# {
137-
# description = "${var.prefix}-event notification access from vpc and schematics"
138-
# enforcement_mode = "enabled"
139-
# account_id = data.ibm_iam_account_settings.iam_account_settings.account_id
140-
# rule_contexts = [{
141-
# attributes = [
142-
# {
143-
# "name" : "endpointType",
144-
# "value" : "private"
145-
# },
146-
# {
147-
# name = "networkZoneId"
148-
# value = module.cbr_vpc_zone.zone_id
149-
# }]
150-
# }, {
151-
# attributes = [
152-
# {
153-
# "name" : "endpointType",
154-
# "value" : "private"
155-
# },
156-
# {
157-
# name = "networkZoneId"
158-
# value = module.cbr_zone_schematics.zone_id
159-
# }]
160-
# }]
161-
# }
162-
# ]
132+
cbr_rules = [
133+
{
134+
description = "${var.prefix}-event notification access from vpc and schematics"
135+
enforcement_mode = "enabled"
136+
account_id = data.ibm_iam_account_settings.iam_account_settings.account_id
137+
rule_contexts = [{
138+
attributes = [
139+
{
140+
"name" : "endpointType",
141+
"value" : "private"
142+
},
143+
{
144+
name = "networkZoneId"
145+
value = module.cbr_vpc_zone.zone_id
146+
}]
147+
}, {
148+
attributes = [
149+
{
150+
"name" : "endpointType",
151+
"value" : "private"
152+
},
153+
{
154+
name = "networkZoneId"
155+
value = module.cbr_zone_schematics.zone_id
156+
}]
157+
}]
158+
}
159+
]
163160
}

examples/fscloud/provider.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,4 +5,5 @@
55
provider "ibm" {
66
ibmcloud_api_key = var.ibmcloud_api_key
77
region = var.region
8+
visibility = "private"
89
}

0 commit comments

Comments
 (0)