Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Aug 9, 2024

Description

Avoid errors in DA when using existing resources (#265)

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested review from Aashiq-J and Ak-sky as code owners August 9, 2024 17:46
@shemau shemau marked this pull request as draft August 9, 2024 17:46
@shemau
Copy link
Contributor Author

shemau commented Aug 9, 2024

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Aug 10, 2024

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Aug 16, 2024

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Aug 16, 2024

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Aug 20, 2024

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Aug 20, 2024

The pipelines previous run failed on an unrelated and known error with CBRs.

@shemau
Copy link
Contributor Author

shemau commented Aug 20, 2024

/run pipeline

@shemau shemau marked this pull request as ready for review August 20, 2024 20:02
@shemau
Copy link
Contributor Author

shemau commented Aug 28, 2024

/run pipeline

@ocofaigh
Copy link
Contributor

/run pipeline

@ocofaigh ocofaigh merged commit bd098f6 into main Sep 24, 2024
2 checks passed
@ocofaigh ocofaigh deleted the existing branch September 24, 2024 10:21
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.10.18 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ocofaigh
Copy link
Contributor

@shemau I think this may of caused a regression -> #299

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants