Skip to content

Conversation

@akocbek
Copy link
Contributor

@akocbek akocbek commented Sep 26, 2024

Description

Issue: #299

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@akocbek
Copy link
Contributor Author

akocbek commented Sep 26, 2024

/run pipeline

tests/pr_test.go Outdated

prefix := fmt.Sprintf("en-existing-%s", strings.ToLower(random.UniqueId()))
// realTerraformDir := "./existing-resources"
// tempTerraformDir, _ := files.CopyTerraformFolderToTemp(realTerraformDir, fmt.Sprintf(prefix+"-%s", strings.ToLower(random.UniqueId())))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove code comments

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you incorrectly committed a directory tests/existing-resources copy

@akocbek
Copy link
Contributor Author

akocbek commented Sep 26, 2024

/run pipeline

@akocbek
Copy link
Contributor Author

akocbek commented Sep 26, 2024

2024/09/26 14:16:55 Terraform apply | module.cbr_vpc_zone.ibm_cbr_zone.cbr_zone[0]: Still creating... [1m50s elapsed]
 2024/09/26 14:17:05 Terraform apply | 
 2024/09/26 14:17:05 Terraform apply | Error: context deadline exceeded
 2024/09/26 14:17:05 Terraform apply | 
 2024/09/26 14:17:05 Terraform apply |   with module.cbr_vpc_zone.ibm_cbr_zone.cbr_zone[0],
 2024/09/26 14:17:05 Terraform apply |   on .terraform/modules/cbr_vpc_zone/modules/cbr-zone-module/main.tf line 14, in resource "ibm_cbr_zone" "cbr_zone":
 2024/09/26 14:17:05 Terraform apply |   14: resource "ibm_cbr_zone" "cbr_zone" {
 2024/09/26 14:17:05 Terraform apply | 
 2024/09/26 14:17:05 Terraform apply | 
 2024/09/26 14:17:05 Terraform apply | Error: context deadline exceeded
 2024/09/26 14:17:05 Terraform apply | 
 2024/09/26 14:17:05 Terraform apply |   with module.cbr_zone_schematics.ibm_cbr_zone.cbr_zone[0],
 2024/09/26 14:17:05 Terraform apply |   on .terraform/modules/cbr_zone_schematics/modules/cbr-zone-module/main.tf line 14, in resource "ibm_cbr_zone" "cbr_zone":
 2024/09/26 14:17:05 Terraform apply |   14: resource "ibm_cbr_zone" "cbr_zone" {
 2024/09/26 14:17:05 Terraform apply | 
 2024/09/26 14:17:05 �[1m�[31mTerraform APPLY error: Terraform APPLY errorexit status 1�[39m�[0m
 2024/09/26 14:17:05 �[1m�[31mCould not execute job: Error : Terraform APPLY errorexit status 1�[39m�[0m

rerunning

@akocbek
Copy link
Contributor Author

akocbek commented Sep 26, 2024

/run pipeline

@ocofaigh ocofaigh merged commit 702db73 into main Sep 26, 2024
2 checks passed
@ocofaigh ocofaigh deleted the fix_en_ex branch September 26, 2024 15:34
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.10.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants