Skip to content

Conversation

@arya-girish-k
Copy link
Contributor

@arya-girish-k arya-girish-k commented Sep 22, 2025

Description

Add regex validation in ibm_catalog.json

Git_issue:https://github.ibm.com/GoldenEye/issues/issues/15220

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add regex validation in ibm_catalog.json

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

arya-girish-k commented Sep 23, 2025

Testing screenshots from the UI for cases where null or incorrect values are provided — both are attached.

  • Prefix
image image
  • existing_monitoring_crn
image image
  • existing_event_notification_instance_crn
image image
  • existing_kms_instance_crn
image image
  • existing_kms_root_key_crn
image image
  • existing_cos_instance_crn
image image
  • existing_secrets_manager_instance_crn
image image

@arya-girish-k
Copy link
Contributor Author

/run pipeline

1 similar comment
@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

@arya-girish-k
Copy link
Contributor Author

/run pipeline

Copy link
Contributor

@mukulpalit-ibm mukulpalit-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ocofaigh ocofaigh merged commit c7d20ae into main Sep 30, 2025
2 checks passed
@ocofaigh ocofaigh deleted the en-regex branch September 30, 2025 07:33
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants