fix: addressed PR comments

Author: vbontempi

solutions/fully-configurable/main.tf

@@ -27,12 +27,6 @@ data "ibm_container_cluster_config" "cluster_config" {
   cluster_name_id = local.cluster_id
 }
 
-# Wait time to allow cluster refreshes components after provisioning
-resource "time_sleep" "wait_45_seconds" {
-  depends_on      = [data.ibm_container_cluster_config.cluster_config]
-  create_duration = "45s"
-}
-
 ##################################################################
 # ESO deployment configuration
 # Configures ESO and reloader deployments

solutions/fully-configurable/version.tf

@@ -9,10 +9,6 @@ terraform {
       source  = "hashicorp/helm"
       version = ">= 2.11.0"
     }
-    time = {
-      source  = "hashicorp/time"
-      version = ">= 0.9.1"
-    }
     ibm = {
       source  = "IBM-Cloud/ibm"
       version = ">= 1.62.0"

tests/pr_test.go

@@ -782,9 +782,6 @@ func TestRunFullConfigSolutionUpgradeSchematics(t *testing.T) {
 	// start main schematics test
 	options := setupSolutionSchematicOptions(t, "eso-fupg", fullConfigSolutionDir)
 
-	// TODO TO REMOVE
-	options.SkipTestTearDown = true
-
 	options.TerraformVars = getFullConfigSolutionTestVariables(options, existingResourceOptions)
 
 	err := options.RunSchematicUpgradeTest()