refactor: Update iam_service_id to iam_id

[arya-girish-k]

Description

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[arya-girish-k]

/run pipeline

[arya-girish-k]

Pipeline is failing with this error

terraform.go:237:
        	Error Trace:	/go/pkg/mod/github.com/terraform-ibm-modules/[email protected]/testhelper/terraform.go:237
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/[email protected]/testschematic/tests.go:273
        	            				/go/pkg/mod/github.com/terraform-ibm-modules/[email protected]/testschematic/tests.go:28
        	            				/__w/terraform-ibm-external-secrets-operator/terraform-ibm-external-secrets-operator/tests/pr_test.go:770
        	Error:      	Should be false
        	Test:       	TestRunFullConfigSolutionSchematics
        	Messages:   	Resource(s) identified to be destroyed
        	            	Name: cluster_secrets_store_secrets_puller_policy
        	            	Address: ibm_iam_service_policy.cluster_secrets_store_secrets_puller_policy["css-1.csg0"]
        	            	Actions: [delete create]
        	            	DIFF:
        	            	  Before:
        	            		{"iam_id":"iam-ServiceId-57ffbeef-22b0-42b6-8520-14a2581f4661","iam_service_id":"ServiceId-57ffbeef-22b0-42b6-8520-14a2581f4661","id":"iam-ServiceId-57ffbeef-22b0-42b6-8520-14a2581f4661/a6624d1d-0a7f-4a6f-b240-7480cb78c25a","resources":"SECURE_VALUE_HIDDEN_HASH:-6f4a58774958d0bbcbed5c925a37a0676d25c76e646cd8cdfbee6425","transaction_id":"ea443e604b7a46bcb2e2c2a198cef058"}
        	            	  After:
        	            		{"iam_id":"ServiceId-57ffbeef-22b0-42b6-8520-14a2581f4661","resources":"SECURE_VALUE_HIDDEN_HASH:-7013fb1b9880f6b999ae9a2f484d9ea496f9c54fe18ac50f250e57f2"}
        	            	
        	            	Change Detail:
        	            	{
        	            	  "actions": [
        	            	    "delete",
        	            	    "create"
        	            	  ],
        	            	  "after": {
        	            	    "account_management": false,
        	            	    "description": null,
        	            	    "iam_id": "ServiceId-57ffbeef-22b0-42b6-8520-14a2581f4661",
        	            	    "pattern": null,
        	            	    "resource_attributes": "SECURE_VALUE_HIDDEN_HASH:-72fa246b3e230e9798957776ed435b246d41b098975e90bada10f9db",
        	            	    "resource_tags": "SECURE_VALUE_HIDDEN_HASH:-eecbbe0c4ff6751b1335c367a064bee17a9b32fb2451585e474e4ece",
        	            	    "resources": "SECURE_VALUE_HIDDEN_HASH:-5000a2bae0fc43bcd382fc797c729afa6bfd6430901b58d5c1b2118e",
        	            	    "roles": "SECURE_VALUE_HIDDEN_HASH:-b127b5498c6137a07a301c05ca3290fcc143afbbcb7196e09370522a",
        	            	    "rule_conditions": "SECURE_VALUE_HIDDEN_HASH:-68898785627043ab8e623db57d03d3b07877fd76bf8c0756ddb6e509",
        	            	    "rule_operator": null,
        	            	    ```

[ocofaigh]

what is thing being added?

[ocofaigh]

@arya-girish-k Can you see if this is still an issue on latest provider version? I think they fixed the issue causing the breaking change.
If not, it doesn't really matter for this PR - we can skip the upgrade test because your only changing the example, not the module code.