Skip to content

Conversation

@ocofaigh
Copy link
Contributor

@ocofaigh ocofaigh commented Feb 17, 2025

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@ocofaigh
Copy link
Contributor Author

/run pipeline

@ocofaigh
Copy link
Contributor Author

The test failed with:

│ Error: ---
│ id: terraform-184925c5
│ summary: 'Error waiting for resource IbmSmPublicCertificate (us-south/79c6d411-c18f-4670-b009-b0044a238667/a332a500-ada7-89c1-febd-9d36afa0e68b)
│   to be created: unexpected state ''deactivated'', wanted target ''active''. last
│   error: %!s(<nil>)'
│ severity: error
│ resource: ibm_sm_public_certificate
│ operation: create
│ component:
│   name: github.com/IBM-Cloud/terraform-provider-ibm
│   version: 1.75.2
│ ---

Since it is unrelated to the git submodule update, I'm going to force merge this PR (to unblock other PRs), and work with the team to find out why we got that error in the tests

@ocofaigh ocofaigh merged commit 523ca44 into main Feb 18, 2025
1 of 2 checks passed
@ocofaigh ocofaigh deleted the cda branch February 18, 2025 10:55
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants