Updating main branch with latest LSF-DA codebase (#248)

* Pushing LSF-DA latest codebase to public repo

* fixing output for app center (#247)

* fixing output

* fixing branch name

---------

Co-authored-by: Nupur Goyal <[email protected]>

* BMS Data Fix - DA LSF (#246)

* BMS Data Fix - DA LSF

* BMS Data Fix - DA LSF

* BMS Data Fix - DA LSF

* updating common-dev-assets

* fixing cra

* fixing cra

* fixing detect-secrets

* Added negative test cases and refactored LSF test structure under lsf_tests directory (#249)

* Added negative test cases and refactored LSF test structure under lsf_tests directory

* fixed pre-commit issues

---------

Co-authored-by: Anbunithi-R <[email protected]>

* fixing pre-commit

* Fixing Deployment issues with Schematics (#250)

* Fixing Ansible repo issue

* Fixing Ansible repo issue

* Fixing Ansible repo issue

* Fixing Ansible repo issue

* Fixing Ansible repo issue

* Fixing Ansible repo issue

* Fixing Ansible repo issue

---------

Co-authored-by: Anand.Reddy7 <[email protected]>

* Add custom logger and validate environment variable setup in PR test (#251)

Co-authored-by: Anbunithi-R <[email protected]>

* Updating outputs (#252)

* fixing output

* fixing branch

---------

Co-authored-by: Nupur Goyal <[email protected]>

* updated default crn value (#253)

Co-authored-by: Anbunithi-R <[email protected]>

* Convert elapsed time to minutes in report; update KP region logic and refactor VPC test cases (#254)

Co-authored-by: Anbunithi-R <[email protected]>

* Update KMS Test to Skip IAM Block Storage Authorization Policy (#256)

Co-authored-by: Anbunithi-R <[email protected]>

* Enhancing LDAP Password Complexity Requirements (#257)

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

---------

Co-authored-by: Anand.Reddy7 <[email protected]>

* Login Host BUG - DA LSF (#258)

* Enhancing LDAP Password Complexity Requirements (#261)

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

* Enhancing LDAP Password Complexity Requirements

Signed-off-by: Anand.Reddy7 <[email protected]>

---------

Signed-off-by: Anand.Reddy7 <[email protected]>
Co-authored-by: Anand.Reddy7 <[email protected]>

* Fix TestRunMultiProfileStaticAndDynamic, extend invalid config tests, and add TestObservabilityAtrackerWithCosAndCloudLogs (#262)

Co-authored-by: Anbunithi-R <[email protected]>

* Fixing Login node unreachable (#263)

* Fixing the Login node un-rechable issue

* Fixing the Login node un-rechable issue

* Fixing the Login node un-rechable issue

* Fixing the Login node un-rechable issue

* Fixing the Login node un-rechable issue

* Fixing the Login node un-rechable issue

* Fixing the Login node un-rechable issue

* Fixing the Login node un-rechable issue

---------

Co-authored-by: Anand.Reddy7 <[email protected]>

* removing scc legacy instance and adding scc-workload-protection (#259)

* scc wp changes

* added a new changes

* adding cloud monitoring crn

* app config plan added

* sample files

* removing scc legacy instance and monitoring for scc-wp

* updating versions

* fixing api issue

* fixing pre-commit

* adding push on the description and json file

* fixing resource group issue

* fixing app config plan

* update the descriptions

* added variable

* fixing desc

* fixing desc

---------

Co-authored-by: Sagar BK <[email protected]>
Co-authored-by: Nupur Goyal <[email protected]>

* catalog.json

* Add invalid instance profile validation tests and support SCCWP + CSPM config (#264)

- Added TestInvalidInstanceProfiles with multiple negative scenarios
- Renamed ValidateBasicClusterConfigurationWithSCC → WithSCCWPAndCSPM
- Created TestRunSCCWPAndCSPMEnabledClusterValidation
- Removed legacy SCC variables
- Added SCCWP/CSPM config: sccwp_enable, cspm_enabled, etc.
- Updated YAML, deployment logic, and lsf_setup.go

Co-authored-by: Anbunithi-R <[email protected]>

---------

Signed-off-by: Anand.Reddy7 <[email protected]>
Co-authored-by: Nupur Goyal <[email protected]>
Co-authored-by: Louies-Jhony <[email protected]>
Co-authored-by: Anbunithi-dev <[email protected]>
Co-authored-by: Anbunithi-R <[email protected]>
Co-authored-by: Anand Reddy <[email protected]>
Co-authored-by: Anand.Reddy7 <[email protected]>
Co-authored-by: Sagar BK <[email protected]>

Author: 8 people

.catalog-onboard-pipeline.yaml

@@ -2,10 +2,10 @@
 apiVersion: v1
 offerings:
 # below is an example of a Deployable Architecture (DA) solution
-- name: deploy-arch-ibm-hpc-lsf # must match the offering name in the ibm_catalog.json
+- name: deploy-arch-ibm-hpc # must match the offering name in the ibm_catalog.json
   kind: solution
-  catalog_id: 0d89ec0d-d39a-494d-ac5b-9d940d8cc65f
-  offering_id: 1444e20a-af22-40d1-af98-c880918849cb
+  catalog_id: 8611e025-10b2-488e-8261-a7f584a5114b
+  offering_id: bf3c07f8-5a62-4289-8ea0-94dbb2b410e6
   # list all of the variations (flavors) you have included in the ibm_catalog.json
   variations:
     - name: Cluster-with-LSF

.cra/.fileignore

@@ -0,0 +1,3 @@
+# ignore temporary copies of referenced repos
+.terraform
+common-dev-assets

.gitignore

@@ -58,3 +58,6 @@ localtweak__*.tf
 
 # tests folder log file
 *.log
+
+# Ignore RSA files
+*id_rsa

.secrets.baseline

@@ -1,9 +1,9 @@
 {
   "exclude": {
-    "files": "acceptance-test/package-lock.json|test/go.sum|go.sum|^.secrets.baseline$",
+    "files": "^.secrets.baseline$",
     "lines": null
   },
-  "generated_at": "2025-02-12T12:53:44Z",
+  "generated_at": "2025-06-19T07:38:57Z",
   "plugins_used": [
     {
       "name": "AWSKeyDetector"
@@ -76,7 +76,34 @@
       "name": "TwilioKeyDetector"
     }
   ],
-  "results": {},
+  "results": {
+    "samples/configs/hpc_catalog_values.json": [
+      {
+        "hashed_secret": "5073c7ac17500ef0678aebc7138a996b4f75d623",
+        "is_secret": true,
+        "is_verified": false,
+        "line_number": 8,
+        "type": "Secret Keyword",
+        "verified_result": null
+      },
+      {
+        "hashed_secret": "1f5e25be9b575e9f5d39c82dfd1d9f4d73f1975c",
+        "is_secret": true,
+        "is_verified": false,
+        "line_number": 37,
+        "type": "Secret Keyword",
+        "verified_result": null
+      },
+      {
+        "hashed_secret": "b295b04949a98dc50ba65adcddd588077b93ab3c",
+        "is_secret": true,
+        "is_verified": false,
+        "line_number": 60,
+        "type": "Secret Keyword",
+        "verified_result": null
+      }
+    ]
+  },
   "version": "0.13.1+ibm.62.dss",
   "word_list": {
     "file": null,

.tekton/lsf-da-longterm/lsf-da-pr-pipeline/listener-git-pr-status.yaml

@@ -0,0 +1,180 @@
+---
+apiVersion: tekton.dev/v1beta1
+kind: TriggerTemplate
+args: [--allow-multiple-documents]
+metadata:
+  name: triggertemplate-git-pr-status
+spec:
+  params:
+    - name: git_access_token
+      description: the token to access the git repository for the clone operations
+    - name: repository
+      description: The git repo
+      default: " "
+    - name: branch
+      description: the branch for the git repo
+    - name: directory-name
+      default: "."
+    - name: pr-repository
+      description: The source git repo for the PullRequest
+      default: " "
+    - name: pr-branch
+      description: The source branch for the PullRequest
+      default: " "
+    - name: pr-revision
+      description: the commit id/sha for the PullRequest
+      default: " "
+    - name: triggerName
+      default: "git-pr-process"
+    - name: pipeline-debug
+      default: "0"
+    - name: zone
+      default: ""
+      description: The IBM Cloud zone name within the selected region where the IBM Cloud HPC cluster should be deployed and requires a single zone input value. Supported zones are eu-de-2 and eu-de-3 for eu-de, us-east-1 and us-east-3 for us-east, and us-south-1 for us-south. The management nodes, file storage shares, and compute nodes will be deployed in the same zone.[Learn more](https://cloud.ibm.com/docs/vpc?topic=vpc-creating-a-vpc-in-a-different-region#get-zones-using-the-cli).
+    - name: resource_group
+      description: Resource group name from your IBM Cloud account where the VPC resources should be deployed. Note. If the resource group value is set as null, automation creates two different RG with the name (workload-rg and service-rg). For additional information on resource groups, see [Managing resource groups](https://cloud.ibm.com/docs/account?topic=account-rgs).
+      default: Default
+    - name: compute_image_name_rhel
+      description: Name of the custom image that you want to use to create virtual server instances in your IBM Cloud account to deploy the IBM Cloud HPC cluster dynamic compute nodes. By default, the solution uses a RHEL 8-6 OS image with additional software packages mentioned [here](https://cloud.ibm.com/docs/hpc-spectrum-LSF#create-custom-image). The solution also offers, Ubuntu 22-04 OS base image (hpcaas-lsf10-ubuntu2204-compute-v1). If you would like to include your application-specific binary files, follow the instructions in [ Planning for custom images ](https://cloud.ibm.com/docs/vpc?topic=vpc-planning-custom-images) to create your own custom image and use that to build the IBM Cloud HPC cluster through this offering.
+      default: ""
+    - name: compute_image_name_ubuntu
+      description: Name of the custom image that you want to use to create virtual server instances in your IBM Cloud account to deploy the IBM Cloud HPC cluster dynamic compute nodes. By default, the solution uses a RHEL 8-6 OS image with additional software packages mentioned [here](https://cloud.ibm.com/docs/hpc-spectrum-LSF#create-custom-image). The solution also offers, Ubuntu 22-04 OS base image (hpcaas-lsf10-ubuntu2204-compute-v1). If you would like to include your application-specific binary files, follow the instructions in [ Planning for custom images ](https://cloud.ibm.com/docs/vpc?topic=vpc-planning-custom-images) to create your own custom image and use that to build the IBM Cloud HPC cluster through this offering.
+      default: ""
+    - name: login_image_name
+      description: Name of the custom image that you want to use to create virtual server instances in your IBM Cloud account to deploy the IBM Cloud HPC cluster login node. By default, the solution uses a RHEL 8-6 OS image with additional software packages mentioned [here](https://cloud.ibm.com/docs/hpc-spectrum-LSF#create-custom-image). The solution also offers, Ubuntu 22-04 OS base image (hpcaas-lsf10-ubuntu2204-compute-v2). If you would like to include your application-specific binary files, follow the instructions in [ Planning for custom images ](https://cloud.ibm.com/docs/vpc?topic=vpc-planning-custom-images) to create your own custom image and use that to build the IBM Cloud HPC cluster through this offering.
+      default: ""
+    - name: management_image_name
+      description: Name of the custom image that you want to use to create virtual server instances in your IBM Cloud account to deploy the IBM Cloud HPC cluster management nodes. By default, the solution uses a RHEL88 base image with additional software packages mentioned [here](https://cloud.ibm.com/docs/ibm-spectrum-lsf#create-custom-image). If you would like to include your application-specific binary files, follow the instructions in [ Planning for custom images ](https://cloud.ibm.com/docs/vpc?topic=vpc-planning-custom-images) to create your own custom image and use that to build the IBM Cloud HPC cluster through this offering.
+      default: ""
+    - name: deployer_image_name
+      description: Name of the deployer image.
+      default: ""
+    - name: cos_region
+      description: The cos region name.
+      default: ""
+    - name: cos_bucket
+      description: The cos bucket name.
+      default: ""
+    - name: cos_instance_crn
+      description: The cos instance crn.
+      default: ""
+    - name: cos_api_key
+      description: The cos account api key.
+      default: ""
+    - name: hpc_custom_reports_repo
+      description: The HPC custom reports storage repository.
+      default: ""
+    - name: hpc_custom_reports_branch
+      description: The HPC custom reports storage repository branch.
+      default: "main"
+    - name: git_user_name
+      description: The git user name.
+      default: ""
+    - name: git_user_email
+      description: The git user email.
+      default: ""
+    - name: solution
+      description: Provide the value for the solution that is needed for the support of lsf and HPC.
+      default: "lsf"
+  resourcetemplates:
+    - apiVersion: v1
+      kind: PersistentVolumeClaim
+      metadata:
+        name: $(params.triggerName)-$(uid)-pvc
+      spec:
+        resources:
+          requests:
+            storage: 5Gi
+        volumeMode: Filesystem
+        accessModes:
+          - ReadWriteOnce
+    - apiVersion: tekton.dev/v1beta1
+      kind: PipelineRun
+      metadata:
+        name: $(params.triggerName)-$(uid)
+      spec:
+        pipelineRef:
+          name: pipeline-git-pr-status
+        params:
+          - name: git_access_token
+            value: $(params.git_access_token)
+          - name: repository
+            value: $(params.repository)
+          - name: branch
+            value: $(params.branch)
+          - name: pr-repository
+            value: $(params.pr-repository)
+          - name: pr-branch
+            value: $(params.pr-branch)
+          - name: pr-revision
+            value: $(params.pr-revision)
+          - name: pipeline-debug
+            value: $(params.pipeline-debug)
+          - name: directory-name
+            value: $(params.directory-name)
+          - name: zone
+            value: $(params.zone)
+          - name: resource_group
+            value: $(params.resource_group)
+          - name: compute_image_name_rhel
+            value: $(params.compute_image_name_rhel)
+          - name: compute_image_name_ubuntu
+            value: $(params.compute_image_name_ubuntu)
+          - name: login_image_name
+            value: $(params.login_image_name)
+          - name: management_image_name
+            value: $(params.management_image_name)
+          - name: deployer_image_name
+            value: $(params.deployer_image_name)
+          - name: cos_region
+            value: $(params.cos_region)
+          - name: cos_bucket
+            value: $(params.cos_bucket)
+          - name: cos_instance_crn
+            value: $(params.cos_instance_crn)
+          - name: cos_api_key
+            value: $(params.cos_api_key)
+          - name: hpc_custom_reports_repo
+            value: $(params.hpc_custom_reports_repo)
+          - name: hpc_custom_reports_branch
+            value: $(params.hpc_custom_reports_branch)
+          - name: git_user_name
+            value: $(params.git_user_name)
+          - name: git_user_email
+            value: $(params.git_user_email)
+          - name: solution
+            value: $(params.solution)
+        workspaces:
+          - name: pipeline-ws
+            persistentVolumeClaim:
+              claimName: $(params.triggerName)-$(uid)-pvc
+---
+apiVersion: tekton.dev/v1beta1
+kind: TriggerBinding
+metadata:
+  name: triggerbinding-git-pr-status-github-pr
+spec:
+  params:
+    - name: repository
+      value: "$(event.pull_request.base.repo.clone_url)"
+    - name: branch
+      value: "$(event.pull_request.base.ref)"
+    - name: pr-repository
+      value: "$(event.pull_request.head.repo.clone_url)"
+    - name: pr-branch
+      value: "$(event.pull_request.head.ref)"
+    - name: pr-revision
+      value: "$(event.pull_request.head.sha)"
+    - name: triggerName
+      value: "github-pullrequest"
+---
+apiVersion: tekton.dev/v1beta1
+kind: EventListener
+metadata:
+  name: eventlistener-git-pr-status-github-pr
+spec:
+  triggers:
+    - binding:
+        name: triggerbinding-git-pr-status-github-pr
+      template:
+        name: triggertemplate-git-pr-status