Skip to content

Conversation

@nupurg-ibm
Copy link
Collaborator

@nupurg-ibm nupurg-ibm commented Jul 12, 2024

Description

Fixing existing bastion login vsi issue
Adding test cases

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@nupurg-ibm nupurg-ibm self-assigned this Jul 12, 2024
@nupurg-ibm
Copy link
Collaborator Author

/run pipeline

Copy link
Contributor

@bksagar bksagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nupurg-ibm nupurg-ibm merged commit 43463c8 into main Jul 12, 2024
@nupurg-ibm nupurg-ibm deleted the 12-july branch July 12, 2024 10:49
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This issue has been resolved in version 1.7.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants