Dedicated Host for Long Term DA for LSF #222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louies-Jhony
requested review from
bksagar,
go-davidng and
nupurg-ibm
as code owners
|
Base branch should be develop here @Louies-Jhony |
nupurg-ibm
reviewed
Apr 17, 2025
| "observability_atracker_enable": ${var.observability_atracker_enable}, | ||
| "observability_atracker_target_type": "${var.observability_atracker_target_type}" | ||
| "observability_atracker_target_type": "${var.observability_atracker_target_type}", | ||
| "enable_dedicated_host": "${var.enable_dedicated_host}" |
There was a problem hiding this comment.
@Louies-Jhony Whichever variables we have for dedicated host child module should be added here as we should provide the provision for users so they can override the optional values as well.
We need to add all variables here so that deployer node should understand the overridden values.
There was a problem hiding this comment.
- The variables for dedicated host child modules are not considered since all the input for the dedicated host depends on the compute_variable profile.
- class, family, profile, count are dependent on compute_instance_variable
- Other variables such as zone, region are already available.
nupurg-ibm
approved these changes
Apr 20, 2025
|
Taken care by #229 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pre-Commit.log
@bksagar @nupurg-ibm - Kindly review the same