Skip to content

Initial commit #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Nov 16, 2023
Merged

Initial commit #45

merged 24 commits into from
Nov 16, 2023

Conversation

@digvijay-ukirde
Copy link
Contributor

Description

Initial Commit

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Initial Commit to get HPC resources created

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

2 similar comments
@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@daniel-butler-irl
Copy link
Contributor

/run pipeline

daniel-butler-irl
daniel-butler-irl previously requested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@daniel-butler-irl daniel-butler-irl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRA-config needs to be updated to point to the basic example (complete example is not implemented)

@daniel-butler-irl
Copy link
Contributor

Test failed because the bucket name was not unique. Add a random string to the prefix with strings.ToLower(random.UniqueId())

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

go-davidng
go-davidng approved these changes Nov 9, 2023
View reviewed changes
Copy link

@go-davidng go-davidng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@digvijay-ukirde
Copy link
Contributor Author

/run pipeline

go-davidng
go-davidng reviewed Nov 16, 2023
View reviewed changes
Copy link

@go-davidng go-davidng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

@digvijay-ukirde digvijay-ukirde merged commit 8bd653b into main Nov 16, 2023
@digvijay-ukirde digvijay-ukirde deleted the develop branch November 16, 2023 20:15
@digvijay-ukirde digvijay-ukirde restored the develop branch November 16, 2023 20:15
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daniel-butler-irl daniel-butler-irl daniel-butler-irl left review comments

@AugieMena3 AugieMena3 Awaiting requested review from AugieMena3

@alexarvinraj alexarvinraj Awaiting requested review from alexarvinraj

+1 more reviewer

@go-davidng go-davidng go-davidng approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@digvijay-ukirde @daniel-butler-irl @terraform-ibm-modules-ops @go-davidng @danielbu-ibm