Skip to content
This repository was archived by the owner on Jun 17, 2025. It is now read-only.

Commit 12a842d

Browse files
iamar7Md Anam Raihan
andauthored
fix: removed tag from ibm_resource_key block - tagging resource keys is not supported by IBM Cloud so no impact to any actual resources here (#44)
Co-authored-by: Md Anam Raihan <[email protected]>
1 parent bbc181e commit 12a842d

File tree

4 files changed

+6
-10
lines changed

4 files changed

+6
-10
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ To attach access management tags to resources in this module, you need the follo
102102
| <a name="input_region"></a> [region](#input\_region) | The region where you want to deploy your instance. | `string` | `"us-south"` | no |
103103
| <a name="input_remote_leader_crn"></a> [remote\_leader\_crn](#input\_remote\_leader\_crn) | A CRN of the leader database to make the replica(read-only) deployment. The leader database is created by a database deployment with the same service ID. A read-only replica is set up to replicate all of your data from the leader deployment to the replica deployment by using asynchronous replication. For more information, see https://cloud.ibm.com/docs/databases-for-enterprisedb?topic=databases-for-enterprisedb-read-only-replicas | `string` | `null` | no |
104104
| <a name="input_resource_group_id"></a> [resource\_group\_id](#input\_resource\_group\_id) | The resource group ID where Enterprise DB instance will be created. | `string` | n/a | yes |
105-
| <a name="input_resource_tags"></a> [resource\_tags](#input\_resource\_tags) | Optional list of tags to be added to the Enterprise DB instance and the associated service credentials (if creating). | `list(string)` | `[]` | no |
105+
| <a name="input_resource_tags"></a> [resource\_tags](#input\_resource\_tags) | Optional list of tags to be added to the Enterprise DB instance. | `list(string)` | `[]` | no |
106106
| <a name="input_service_credential_names"></a> [service\_credential\_names](#input\_service\_credential\_names) | Map of name, role for service credentials that you want to create for the database | `map(string)` | `{}` | no |
107107
| <a name="input_service_endpoints"></a> [service\_endpoints](#input\_service\_endpoints) | Specify whether you want to enable the public, private, or both service endpoints. Supported values are 'public', 'private', or 'public-and-private'. | `string` | `"private"` | no |
108108
| <a name="input_skip_iam_authorization_policy"></a> [skip\_iam\_authorization\_policy](#input\_skip\_iam\_authorization\_policy) | Set to true to skip the creation of an IAM authorization policy that permits all Enterprise database instances in the resource group to read the encryption key from the KMS instance. If set to false, pass in a value for the KMS instance in the existing\_kms\_instance\_guid variable. In addition, no policy is created if var.kms\_encryption\_enabled is set to false. | `bool` | `false` | no |

main.tf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -182,7 +182,6 @@ resource "ibm_resource_key" "service_credentials" {
182182
name = each.key
183183
role = each.value
184184
resource_instance_id = ibm_database.enterprise_db.id
185-
tags = var.resource_tags
186185
}
187186

188187
locals {

module-metadata.json

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -288,17 +288,15 @@
288288
"resource_tags": {
289289
"name": "resource_tags",
290290
"type": "list(string)",
291-
"description": "Optional list of tags to be added to the Enterprise DB instance and the associated service credentials (if creating).",
291+
"description": "Optional list of tags to be added to the Enterprise DB instance.",
292292
"default": [],
293293
"source": [
294-
"ibm_database.enterprise_db.tags",
295-
"ibm_resource_key.service_credentials.tags"
294+
"ibm_database.enterprise_db.tags"
296295
],
297296
"pos": {
298297
"filename": "variables.tf",
299298
"line": 101
300299
},
301-
"cloud_data_type": "tags",
302300
"min_length": 1,
303301
"max_length": 128,
304302
"matches": "^[A-Za-z0-9:_ .-]+$",
@@ -510,8 +508,7 @@
510508
"type": "ibm_resource_key",
511509
"name": "service_credentials",
512510
"attributes": {
513-
"for_each": "service_credential_names",
514-
"tags": "resource_tags"
511+
"for_each": "service_credential_names"
515512
},
516513
"provider": {
517514
"name": "ibm"
@@ -554,7 +551,7 @@
554551
},
555552
"pos": {
556553
"filename": "main.tf",
557-
"line": 209
554+
"line": 208
558555
}
559556
}
560557
},

variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ variable "service_endpoints" {
100100

101101
variable "resource_tags" {
102102
type = list(string)
103-
description = "Optional list of tags to be added to the Enterprise DB instance and the associated service credentials (if creating)."
103+
description = "Optional list of tags to be added to the Enterprise DB instance."
104104
default = []
105105
}
106106

0 commit comments

Comments
 (0)