Skip to content
This repository was archived by the owner on Jun 17, 2025. It is now read-only.

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Jan 20, 2025

Description

added some refactors and a deprecation notice.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Jan 20, 2025
@jor2
Copy link
Member Author

jor2 commented Jan 20, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 21, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 21, 2025

/run pipeline

1 similar comment
@jor2
Copy link
Member Author

jor2 commented Jan 21, 2025

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With EDB being deprecated, I suggest to remove the DA code and have all tests running module examples

@ocofaigh
Copy link
Contributor

Also provisioning failed with:

         2025/01/21 17:17:49 Terraform apply |     "Result": {
         2025/01/21 17:17:49 Terraform apply |         "errors": {
         2025/01/21 17:17:49 Terraform apply |             "configuration": [
         2025/01/21 17:17:49 Terraform apply |                 "can't be blank"
         2025/01/21 17:17:49 Terraform apply |             ]
         2025/01/21 17:17:49 Terraform apply |         }
         2025/01/21 17:17:49 Terraform apply |     },

@jor2
Copy link
Member Author

jor2 commented Jan 22, 2025

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Jan 22, 2025

/run pipeline

@ocofaigh ocofaigh merged commit cb76120 into main Jan 23, 2025
2 checks passed
@ocofaigh ocofaigh deleted the kms-refactor branch January 23, 2025 10:51
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.9.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants