Skip to content
This repository was archived by the owner on Jun 17, 2025. It is now read-only.

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Feb 8, 2025

Description

#323 error on the main branch in the complete test.

This is a test issue, so no release is required.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau shemau requested a review from imprateeksh as a code owner February 8, 2025 11:53
@shemau
Copy link
Contributor Author

shemau commented Feb 8, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 8, 2025

These errors are reported (as expected)

TestRunUpgradeCompleteExample 2025-02-08T12:02:29Z retry.go:99: Returning due to fatal error: FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: Invalid index
│ 
│   on main.tf line 103, in module "enterprise_db":103:   kms_key_crn                  = module.key_protect_all_inclusive.keys["icd-edb.${var.prefix}-edb"].crn
│     ├────────────────
│     │ module.key_protect_all_inclusive.keys is object with 2 attributes
│     │ var.prefix is "edb-upg-dehewg"
│ 
│ The given key does not identify an element in this collection value.
╵
╷
│ Error: Invalid index
│ 
│   on main.tf line 104, in module "enterprise_db":104:   backup_encryption_key_crn    = module.key_protect_all_inclusive.keys["icd.${local.data_key_name}"].crn
│     ├────────────────
│     │ local.data_key_name is "edb-upg-dehewg-enterprisedb"
│     │ module.key_protect_all_inclusive.keys is object with 2 attributes
│ 
│ The given key does not identify an element in this collection value.
╵}

These are caused by the bug being fixed on the main branch. The only errors are during upgrade (TestRunUpgradeCompleteExample). The only option is to skip the upgrade test.

@shemau
Copy link
Contributor Author

shemau commented Feb 8, 2025

/run pipeline

Copy link
Member

@imprateeksh imprateeksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@ocofaigh ocofaigh merged commit ff038d3 into main Feb 13, 2025
2 checks passed
@ocofaigh ocofaigh deleted the main-complete-fix branch February 13, 2025 09:43
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants