Skip to content
This repository was archived by the owner on Jun 17, 2025. It is now read-only.

Conversation

@Aditya-ranjan-16
Copy link
Contributor

@Aditya-ranjan-16 Aditya-ranjan-16 commented Mar 18, 2025

Description

https://github.ibm.com/GoldenEye/issues/issues/11680

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Address consistency issues:

  • Renamed several variables for consistency:

    • member_cpu_countcpu_count
    • member_disk_mbdisk_mb
    • member_memory_mbmemory_mb
    • enterprise_db_backup_crnexisting_database_crn
    • resource_tagstags
  • Renamed module "enterprise_db" with module "database"

  • Added a new output: enterprise_db_crn

  • Renamed few Outputs :

    • restored_enterprise_dbrestored_icd_enterprise_db
    • restored_enterprise_db_idrestored_icd_enterprise_db_id
    • restored_enterprise_db_versionrestored_icd_enterprise_db_version
  • Added a new pitr_time variable:

  • Added service_credential_names mapping:

  • Replaced resource_tags with tags across all files.

  • Enhanced CBR rule structure by adding tags and operations fields.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

1 similar comment
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aditya-ranjan-16 Aditya-ranjan-16 removed the request for review from imprateeksh March 25, 2025 10:30
@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

Copy link
Member

@Aayush-Abhyarthi Aayush-Abhyarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Aditya-ranjan-16
Copy link
Contributor Author

/run pipeline

@Aashiq-J Aashiq-J merged commit 1386e24 into main Apr 2, 2025
2 checks passed
@Aashiq-J Aashiq-J deleted the consistency-issues branch April 2, 2025 11:48
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.10.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants