-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add support to use a different KMS key for backup encryption #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
fixed, my bad |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me.
There is no backup test that I could, which is not an issue with this PR, so I raised #337.
2024/11/14 17:13:31 Terraform apply | "Result": {
2024/11/14 17:13:31 Terraform apply | "details": "{\"error\":\"Unauthorized\",\"description\":\"We were unable to complete your request: Unauthorized. Try again with valid permissions or contact support if the issue persists.\"}",
2024/11/14 17:13:31 Terraform apply | "error_code": "RC-ServiceBrokerErrorResponse",
2024/11/14 17:13:31 Terraform apply | "message": "Please contact the Service Provider for this error. [401, Unauthorized] We were unable to complete your request: Unauthorized. Try again with valid permissions or contact support if the issue persists.",
2024/11/14 17:13:31 Terraform apply | "status_code": 502,
2024/11/14 17:13:31 Terraform apply | "transaction_id": "626c-0e77f5656f1a876a"
2024/11/14 17:13:31 Terraform apply | },
2024/11/14 17:13:31 Terraform apply | "RawResult": null
2024/11/14 17:13:31 Terraform apply | }
2024/11/14 17:13:31 Terraform apply |
2024/11/14 17:13:31 Terraform apply |
2024/11/14 17:13:31 Terraform apply | with module.elasticsearch[0].module.elasticsearch.ibm_database.elasticsearch,
2024/11/14 17:13:31 Terraform apply | on ../../main.tf line 85, in resource "ibm_database" "elasticsearch":
2024/11/14 17:13:31 Terraform apply | 85: resource "ibm_database" "elasticsearch" { |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
…terraform-ibm-icd-elasticsearch into backup-encryption
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/run pipeline |
|
/run pipeline |
|
/run pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Review is now stale after updates
|
🎉 This PR is included in version 1.24.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Description
Add support to use a different KMS key for backup encryption
Expose the ability to provision from a backup CRN in the Elasticsearch DA
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
Add support to use a different KMS key for backup encryption
Expose the ability to provision from a backup CRN in the Elasticsearch DA
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers