Skip to content

Conversation

@jor2
Copy link
Member

@jor2 jor2 commented Nov 14, 2024

Description

Add support to use a different KMS key for backup encryption
Expose the ability to provision from a backup CRN in the Elasticsearch DA

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Add support to use a different KMS key for backup encryption

Expose the ability to provision from a backup CRN in the Elasticsearch DA

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@jor2 jor2 self-assigned this Nov 14, 2024
@jor2
Copy link
Member Author

jor2 commented Nov 14, 2024

/run pipeline

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@jor2
Copy link
Member Author

jor2 commented Nov 14, 2024

see comments

fixed, my bad

@jor2 jor2 requested a review from ocofaigh November 14, 2024 16:58
@jor2
Copy link
Member Author

jor2 commented Nov 14, 2024

/run pipeline

shemau
shemau previously approved these changes Nov 14, 2024
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me.

There is no backup test that I could, which is not an issue with this PR, so I raised #337.

@jor2
Copy link
Member Author

jor2 commented Nov 14, 2024

 2024/11/14 17:13:31 Terraform apply |     "Result": {
 2024/11/14 17:13:31 Terraform apply |         "details": "{\"error\":\"Unauthorized\",\"description\":\"We were unable to complete your request: Unauthorized. Try again with valid permissions or contact support if the issue persists.\"}",
 2024/11/14 17:13:31 Terraform apply |         "error_code": "RC-ServiceBrokerErrorResponse",
 2024/11/14 17:13:31 Terraform apply |         "message": "Please contact the Service Provider for this error. [401, Unauthorized] We were unable to complete your request: Unauthorized. Try again with valid permissions or contact support if the issue persists.",
 2024/11/14 17:13:31 Terraform apply |         "status_code": 502,
 2024/11/14 17:13:31 Terraform apply |         "transaction_id": "626c-0e77f5656f1a876a"
 2024/11/14 17:13:31 Terraform apply |     },
 2024/11/14 17:13:31 Terraform apply |     "RawResult": null
 2024/11/14 17:13:31 Terraform apply | }
 2024/11/14 17:13:31 Terraform apply | 
 2024/11/14 17:13:31 Terraform apply | 
 2024/11/14 17:13:31 Terraform apply |   with module.elasticsearch[0].module.elasticsearch.ibm_database.elasticsearch,
 2024/11/14 17:13:31 Terraform apply |   on ../../main.tf line 85, in resource "ibm_database" "elasticsearch":
 2024/11/14 17:13:31 Terraform apply |   85: resource "ibm_database" "elasticsearch" {

@jor2
Copy link
Member Author

jor2 commented Nov 15, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 15, 2024

/run pipeline

@jor2 jor2 requested a review from shemau November 15, 2024 16:33
@jor2
Copy link
Member Author

jor2 commented Nov 18, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 18, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 18, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 18, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 18, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 19, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 20, 2024

/run pipeline

@jor2 jor2 requested a review from ocofaigh November 20, 2024 10:25
@jor2
Copy link
Member Author

jor2 commented Nov 20, 2024

/run pipeline

shemau
shemau previously approved these changes Nov 20, 2024
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jor2
Copy link
Member Author

jor2 commented Nov 25, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Nov 28, 2024

/run pipeline

@jor2
Copy link
Member Author

jor2 commented Dec 2, 2024

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddgiguere toddgiguere dismissed ocofaigh’s stale review December 3, 2024 20:25

Review is now stale after updates

@toddgiguere toddgiguere merged commit 367259a into main Dec 3, 2024
2 checks passed
@toddgiguere toddgiguere deleted the backup-encryption branch December 3, 2024 20:31
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.24.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants