refactor: Update the prefix logic in DA

[arya-girish-k]

Description

Refactored the code logic for prefix variable by adding default value for prefix and marked as required in catalog manifest.Also allowed prefix to be "" (empty string) for advanced users.
#11959

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

Add the default value for prefix variable and mark as required in catalog manifest. Also allowed prefix to be "" (empty string ).

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[arya-girish-k]

/run pipeline

[arya-girish-k]

/run pipeline

[arya-girish-k]

Please find the Test Reference
https://github.ibm.com/GoldenEye/issues/issues/11959#issuecomment-102119340

[arya-girish-k]

The TestRunStandardUpgradeSolution is failing due to the addition of a default value for the prefix variable.
https://github.com/terraform-ibm-modules/terraform-ibm-icd-elasticsearch/actions/runs/12822926652/job/35756729203#step:7:4169

As per the test terraform will execute the following actions:

Update the resource_group, kms_policy, and elastic_search db resources.

Destroy the existing kms_key, kms_key_ring, and kms_key_policy resources.

Create new instances of kms_key, kms_key_ring, and kms_key_policy resources.

Since removing the prefix won't result in a breaking change for the user, So as per the discussion it is fine to skip the upgrade test in this scenario.

[arya-girish-k]

/run pipeline

[arya-girish-k]

/run pipeline

[arya-girish-k]

/run pipeline

[arya-girish-k]

/run pipeline

[shemau]

LGTM.

Consistent with postgresql

[shemau]

@ocofaigh this is consistent with postgresql, in that the default will change. The failing use case will be any DA that uses the default, will see the value change which potentially results in the es instance being deleted and recreated.

[shemau]

/run pipeline

[shemau]

/run pipeline

[shemau]

/run pipeline

[arya-girish-k]

Encountering a similar error on PRs for the ICD databases
Error: Example 2025-01-28T17:31:36Z logger.go:66: │ Error: [ERROR] Error waiting for create database instance (crn:v1:bluemix:public:databases-for-elasticsearch:us-south:a/abac0df06b644a9cabc6e44f55b3880e:42e9f568-856a-4e76-876c-a62f7825653b::) to complete: [ERROR] Error ICD interface not ready after create: crn:v1:bluemix:public:databases-for-elasticsearch:us-south:a/abac0df06b644a9cabc6e44f55b3880e:42e9f568-856a-4e76-876c-a62f7825653b:: with error [ERROR] Error getting database config for: crn:v1:bluemix:public:databases-for-elasticsearch:us-south:a%2Fabac0df06b644a9cabc6e44f55b3880e:42e9f568-856a-4e76-876c-a62f7825653b:: with error Request failed with status code: 500, ServerErrorResponse: {"status":500,"error":"Internal Server Error"}

I have noticed @shemau has already raised support ticket -https://cloud.ibm.com/unifiedsupport/cases/manage/CS4228375?accountId=abac0df06b644a9cabc6e44f55b3880e for the same.Waiting for the issue is being resolved, till then paused working on this PR.

[arya-girish-k]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.26.3 🎉

The release is available on:

• GitHub release
• v1.26.3

Your semantic-release bot 📦🚀