fix: service credential source service role

[shemau]

Description

Issue:

The logic for creating the service credential only worked for roles where the CRN service-name was 'iam'. Syncing this module with the secret manager module, to expose terraform-ibm-modules/terraform-ibm-secrets-manager#268 and the secret module, to expose terraform-ibm-modules/terraform-ibm-secrets-manager-secret#249.

Additional changes are included in pr_test.go to include a cloud-object-service serviceRole based service credential.

The DA does support secret creation and the internal structure of a complex variable has changed. Any consumer using this feature to create service credentials will have to replace the existing 'service_credentials_source_service_role' with the equivalent 'service_credentials_source_service_role_crn'.
This is a text input in the catalog, the content of the field will not be lost, but it will have to be updated.

Release required?

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

The service_credential_secrets variable that previously set 'service_credentials_source_service_role' property in an object, now needs to set 'service_credentials_source_service_role_crn'. The CRN for the role to give the service credential in the source service. These can be looked up at https://cloud.ibm.com/iam/roles, select the service and select the role to view the CRN for that role.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

For mergers

• Use a conventional commit message to set the release level. Follow the guidelines.
• Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
• Use the Squash and merge option.

[shemau]

/run pipeline

[shemau]

/run pipeline

[shemau]

/run pipeline

[shemau]

/run pipeline

[ocofaigh]

/run pipeline

[terraform-ibm-modules-ops]

🎉 This PR is included in version 1.27.0 🎉

The release is available on:

• GitHub release
• v1.27.0

Your semantic-release bot 📦🚀