Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Feb 8, 2025

Description

This is a clean up with pre-commit and jq. There are no changes that require release.

There are only two changes in ibm_catalog.json.
Line 64 is split into 2 lines for formatting.
White space is trimmed (all lines).

This will not result in changes to the catalog tile.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau
Copy link
Contributor Author

shemau commented Feb 8, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 9, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 10, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 10, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 10, 2025

/run pipeline

@shemau shemau mentioned this pull request Feb 13, 2025
1 task
@shemau
Copy link
Contributor Author

shemau commented Feb 14, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 18, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 18, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Feb 20, 2025

This is a trivial change for consistency. Review file changes without white space https://github.com/terraform-ibm-modules/terraform-ibm-icd-elasticsearch/pull/398/files?w=1

@ocofaigh ocofaigh merged commit 7ff7ef3 into main Feb 20, 2025
2 checks passed
@ocofaigh ocofaigh deleted the ibm-catalog branch February 20, 2025 16:51
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.30.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants