Skip to content

feat: Support to pass image credentials #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Aug 4, 2025
Merged

feat: Support to pass image credentials #448

merged 44 commits into from
Aug 4, 2025

Conversation

@aatreyee2506
Copy link
Contributor

@aatreyee2506 aatreyee2506 commented Apr 21, 2025 •
edited by Ak-sky
Loading

Description

Added support to pass image credentials when pulling kibana image from a private registry.
Git_issue

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Added support for passing image pull credentials when deploying Kibana from a private registry.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 changed the title ADD: Support to pass image credentials Add: Support to pass image credentials Apr 21, 2025
@aatreyee2506 aatreyee2506 marked this pull request as ready for review April 21, 2025 08:15
@aatreyee2506
Copy link
Contributor Author

Case 1:
with image-secret:
Screenshot 2025-04-21 at 1 39 02 PM

Case 2:
without image-secret:
Screenshot 2025-04-18 at 5 10 35 PM

@aatreyee2506 aatreyee2506 changed the title Add: Support to pass image credentials chore: Support to pass image credentials Apr 21, 2025
@aatreyee2506 aatreyee2506 changed the title chore: Support to pass image credentials feat: Support to pass image credentials Apr 21, 2025
@Ak-sky
Copy link
Member

Ak-sky commented Apr 21, 2025 •
edited
Loading

Case 1: with image-secret: Screenshot 2025-04-21 at 1 39 02 PM

Case 2: without image-secret: Screenshot 2025-04-18 at 5 10 35 PM

I am seeing docker pull command, why are we doing this? This should be done by TF when setting credentials for the TF to pull the Kibana image.

@Ak-sky
Copy link
Member

Ak-sky commented Apr 21, 2025 •
edited
Loading

@aatreyee2506 , Also are we allowed to use docker?

Ak-sky
Ak-sky reviewed Apr 21, 2025
View reviewed changes
@Ak-sky
Copy link
Member

Ak-sky commented Apr 24, 2025

@aatreyee2506 , Also are we allowed to use docker?

Ok we can use Docker engine and not docker desktop.

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee2506 aatreyee2506 marked this pull request as draft May 8, 2025 08:17
@aatreyee2506
Copy link
Contributor Author

/run pipeline

@aatreyee257
Copy link
Contributor

/run pipeline

@aatreyee257 aatreyee257 marked this pull request as ready for review June 4, 2025 07:03
@aatreyee257
Copy link
Contributor

/run pipeline

@aatreyee257
Copy link
Contributor

/run pipeline

@aatreyee257 aatreyee257 requested a review from shemau July 15, 2025 08:52
@daniel-butler-irl
Copy link
Contributor

@aatreyee2506 Since there is no test for this (@ocofaigh do you think one is needed?), can you confirm you deployed this and it all works as expected?

@aatreyee257
Copy link
Contributor

/run pipeline

@aatreyee257
Copy link
Contributor

/run pipeline

@aatreyee257
Copy link
Contributor

/run pipeline

@aatreyee257
Copy link
Contributor

/run pipeline

@aatreyee257
Copy link
Contributor

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Jul 31, 2025

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Jul 31, 2025

/run pipeline

@Ak-sky
Copy link
Member

Ak-sky commented Jul 31, 2025

/run pipeline

shemau
shemau approved these changes Aug 1, 2025
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ak-sky
Copy link
Member

Ak-sky commented Aug 4, 2025

/run pipeline

@toddgiguere toddgiguere merged commit 22d9a64 into main Aug 4, 2025
2 checks passed
@toddgiguere toddgiguere deleted the issue-12003 branch August 4, 2025 13:33
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aatreyee257 aatreyee257 aatreyee257 left review comments

@shemau shemau shemau approved these changes

@daniel-butler-irl daniel-butler-irl Awaiting requested review from daniel-butler-irl daniel-butler-irl is a code owner

@Ak-sky Ak-sky Awaiting requested review from Ak-sky

Assignees

@aatreyee257 aatreyee257

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@aatreyee2506 @Ak-sky @aatreyee257 @shemau @daniel-butler-irl @terraform-ibm-modules-ops @toddgiguere @whoffler