Skip to content

Conversation

@Aayush-Abhyarthi
Copy link
Member

@Aayush-Abhyarthi Aayush-Abhyarthi commented May 6, 2025

Description

https://github.ibm.com/GoldenEye/issues/issues/12398

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Upgrade to terraform 1.9.0.
Update to use cross object referencing.

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

Copy link
Contributor

@mukulpalit-ibm mukulpalit-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mukulpalit-ibm
Copy link
Contributor

If you can add the test cases for the two extra validation present in this ICD and it will be helpful

@Aayush-Abhyarthi
Copy link
Member Author

Tested out the 2 cases and it throws the error as expected.

Screenshot 2025-05-21 at 1 15 32 PM
Screenshot 2025-05-21 at 1 22 45 PM

@Aayush-Abhyarthi
Copy link
Member Author

/run pipeline

Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Compared redis main.

@Aashiq-J Aashiq-J merged commit 9d01af7 into main May 23, 2025
2 checks passed
@Aashiq-J Aashiq-J deleted the cross-obj branch May 23, 2025 04:27
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 1.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants