Skip to content

chore: fix regex validation to enforce exact match (public or private) #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 11, 2025
Merged

chore: fix regex validation to enforce exact match (public or private) #520

merged 6 commits into from
Sep 11, 2025

Conversation

@piyush117
Copy link
Contributor

@piyush117 piyush117 commented Sep 3, 2025 •
edited
Loading

https://github.ibm.com/GoldenEye/issues/issues/15651
Fix regex validation to enforce exact match (public or private)

@piyush117
Copy link
Contributor Author

/run pipeline

1 similar comment
@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117 piyush117 changed the title chore: Fix regex validation to enforce exact match (public or private) chore: fix regex validation to enforce exact match (public or private) Sep 3, 2025
shemau
shemau previously requested changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@shemau shemau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of other instances of the pattern being fixed.

Not 100% match, but the same logic applies to service_endpoints.

    condition     = can(regex("public|public-and-private|private", var.service_endpoints))

in 2 places.

@piyush117
Copy link
Contributor Author

/run pipeline

1 similar comment
@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117
Copy link
Contributor Author

/run pipeline

1 similar comment
@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117
Copy link
Contributor Author

/run pipeline

@piyush117
Copy link
Contributor Author

/run pipeline

@ocofaigh ocofaigh merged commit e5aff74 into main Sep 11, 2025
2 checks passed
@ocofaigh ocofaigh deleted the update_regex branch September 11, 2025 09:45
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.3.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ocofaigh ocofaigh ocofaigh approved these changes

@shemau shemau shemau left review comments

@daniel-butler-irl daniel-butler-irl Awaiting requested review from daniel-butler-irl daniel-butler-irl is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@piyush117 @terraform-ibm-modules-ops @shemau @ocofaigh