Skip to content

Conversation

@shemau
Copy link
Contributor

@shemau shemau commented Sep 10, 2025

Description

Feature to set the deployable architecture auto scale input to use the code editor and provide a default value.

There are no migration issues, either

  • an override is specified, in which case the existing one will still be used.
    or
  • no override is specified, in which case one will be added that matches the value already in the state file.

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@shemau
Copy link
Contributor Author

shemau commented Sep 15, 2025

/run pipeline

2 similar comments
@piyush117
Copy link
Contributor

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Sep 18, 2025

/run pipeline

@rajatagarwal-ibm
Copy link
Member

@shemau pre-commit seems to be failing for this one

@shemau
Copy link
Contributor Author

shemau commented Oct 1, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Oct 1, 2025

         2025/10/01 14:01:50 Terraform apply | Error: ---
         2025/10/01 14:01:50 Terraform apply | id: terraform-23dab597
         2025/10/01 14:01:50 Terraform apply | summary: |-
         2025/10/01 14:01:50 Terraform apply |   database user (kibana_system) validation error:
         2025/10/01 14:01:50 Terraform apply |   password must not begin with a special character (_-)

This test does not touch the kibana password code. I will raise an issue and re-run the tests here, given a 2 in 54 chance of failure.

@shemau
Copy link
Contributor Author

shemau commented Oct 1, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Oct 2, 2025

         2025/10/01 16:46:54 Terraform apply | Error: ---
         2025/10/01 16:46:54 Terraform apply | id: terraform-23dab597
         2025/10/01 16:46:54 Terraform apply | summary: |-
         2025/10/01 16:46:54 Terraform apply |   database user (kibana_system) validation error:
         2025/10/01 16:46:54 Terraform apply |   password must not begin with a special character (_-)

Same error. I will re-try one more time and start looking at a fix.

@shemau
Copy link
Contributor Author

shemau commented Oct 2, 2025

/run pipeline

@shemau
Copy link
Contributor Author

shemau commented Oct 2, 2025

/run pipeline

@ocofaigh ocofaigh merged commit f454ec2 into main Oct 3, 2025
2 checks passed
@ocofaigh ocofaigh deleted the autoscale-editor branch October 3, 2025 11:35
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.3.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants