[Elasticsearch] Save the Kibana app login password to the SM in DA

[Ak-sky]

[shemau]

Whilst this investigated, can the password be checked.

         2025/10/01 14:01:50 Terraform apply | Error: ---
         2025/10/01 14:01:50 Terraform apply | id: terraform-23dab597
         2025/10/01 14:01:50 Terraform apply | summary: |-
         2025/10/01 14:01:50 Terraform apply |   database user (kibana_system) validation error:
         2025/10/01 14:01:50 Terraform apply |   password must not begin with a special character (_-)

Suggests that either the test password or in code password generation can occasionally start with an invalid character. This is already solved for the admin password, so maybe adopt the same code or pattern for this password.

[shemau]

The kibana system password is an Elasticsearch user password. These can not start with a _-. The following line should fix the issue.

  kibana_system_password    = var.enable_kibana_dashboard ? startswith(random_password.kibana_system_password[0].result, "-") ? "J${substr(random_password.kibana_system_password[0].result, 1, -1)}" : startswith(random_password.kibana_system_password[0].result, "_") ? "K${substr(random_password.kibana_system_password[0].result, 1, -1)}" : random_password.kibana_system_password[0].result : null

If the first character is - change to J, if the first character is _ change to K, otherwise use it unchanged.

The code is at least required in fully configurable, it might also be required in the main module.

I am not sure what the rules on the kibana app are, so a similar change may be required on the app password as well.