fix: bug with validation #383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run pipeline |
shemau
requested changes
Jan 7, 2025
modules/fscloud/variables.tf
Outdated
Comment on lines
171
to
178
| validation { | ||
| condition = anytrue([ | ||
| var.backup_encryption_key_crn == null, | ||
| can(regex(".*kms.*", var.kms_key_crn)), | ||
| can(regex(".*hs-crypto.*", var.kms_key_crn)), | ||
| can(regex(".*kms.*", var.backup_encryption_key_crn)), | ||
| can(regex(".*hs-crypto.*", var.backup_encryption_key_crn)), | ||
| ]) | ||
| error_message = "Value must be the KMS key CRN from a Key Protect or Hyper Protect Crypto Services instance in one of the supported backup regions." | ||
| } |
There was a problem hiding this comment.
Does this whole validation provide any value. It will always be validated in the main module.
|
/run pipeline |
shemau
requested changes
Jan 7, 2025
added 3 commits
January 7, 2025 22:31
…raform-ibm-icd-elasticsearch into fix-validation
|
/run pipeline |
|
/run pipeline |
|
🎉 This PR is included in version 1.25.13 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
there is a bug with variable validation referencing incorrect variable.
Release required?
x.x.X)x.X.x)X.x.x)Release notes content
fix bug with variable validation.
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
For mergers