Skip to content

fully configurable elasticsearch solution #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jun 27, 2025
Merged

fully configurable elasticsearch solution #428

merged 22 commits into from
Jun 27, 2025

Conversation

@whoffler
Copy link
Contributor

@whoffler whoffler commented Mar 24, 2025 •
edited
Loading

For issue - https://github.ibm.com/GoldenEye/issues/issues/12892

Description

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@whoffler whoffler force-pushed the fullyConfigurable branch from 1b94932 to 4550455 Compare March 25, 2025 09:00
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from 4550455 to c91a000 Compare March 26, 2025 14:42
@whoffler
Copy link
Contributor Author

/run pipeline

1 similar comment
@whoffler
Copy link
Contributor Author

whoffler commented May 1, 2025

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from 1afeca2 to 3cde97d Compare May 1, 2025 12:56
@whoffler
Copy link
Contributor Author

whoffler commented May 1, 2025

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch 2 times, most recently from 5018bdc to e4798d0 Compare May 1, 2025 14:17
@whoffler
Copy link
Contributor Author

whoffler commented May 2, 2025

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from a9b6986 to 4a7d4f2 Compare May 2, 2025 07:32
@whoffler
Copy link
Contributor Author

whoffler commented May 2, 2025

/run pipeline

1 similar comment
@whoffler
Copy link
Contributor Author

whoffler commented May 2, 2025

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from 07c0ac4 to d694ebb Compare May 2, 2025 10:12
@whoffler
Copy link
Contributor Author

whoffler commented May 2, 2025

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from d694ebb to 3947525 Compare May 2, 2025 10:46
@whoffler
Copy link
Contributor Author

whoffler commented May 2, 2025

/run pipeline

2 similar comments
@whoffler
Copy link
Contributor Author

whoffler commented May 2, 2025

/run pipeline

@whoffler
Copy link
Contributor Author

whoffler commented May 2, 2025

/run pipeline

whoffler
whoffler commented May 7, 2025
View reviewed changes
@whoffler whoffler force-pushed the fullyConfigurable branch from b1431d5 to 78d311d Compare May 8, 2025 07:39
@whoffler
Copy link
Contributor Author

whoffler commented May 8, 2025

/run pipeline

1 similar comment
@whoffler
Copy link
Contributor Author

whoffler commented May 8, 2025

/run pipeline

whoffler
whoffler commented May 8, 2025
View reviewed changes
@whoffler whoffler force-pushed the fullyConfigurable branch 2 times, most recently from 094e3fc to ffa72c9 Compare May 12, 2025 08:05
@whoffler
Copy link
Contributor Author

/run pipeline

akocbek
akocbek reviewed Jun 25, 2025
View reviewed changes
solutions/fully-configurable/variables.tf
}

variable "skip_es_kms_auth_policy" {
variable "skip_elasticsearch_kms_auth_policy" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check skip_redis_kms_auth_policy in redis, which description is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the elasticsearch description is more accurate

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we need to change in redis

akocbek
akocbek reviewed Jun 25, 2025
View reviewed changes
akocbek
akocbek reviewed Jun 25, 2025
View reviewed changes
akocbek
akocbek reviewed Jun 25, 2025
View reviewed changes
akocbek
akocbek requested changes Jun 25, 2025
View reviewed changes
Copy link
Contributor

@akocbek akocbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes made in fully-configurable, should be added to security-enforced as well

akocbek
akocbek reviewed Jun 26, 2025
View reviewed changes
@whoffler whoffler force-pushed the fullyConfigurable branch from 1d86fe0 to caa7b10 Compare June 26, 2025 11:39
@whoffler whoffler force-pushed the fullyConfigurable branch from caa7b10 to 1e6e255 Compare June 26, 2025 11:50
@whoffler
Copy link
Contributor Author

/run pipeline

1 similar comment
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler
Copy link
Contributor Author

/run pipeline

1 similar comment
@whoffler
Copy link
Contributor Author

/run pipeline

@whoffler whoffler force-pushed the fullyConfigurable branch from 1779b7d to 5df79da Compare June 27, 2025 09:30
@whoffler
Copy link
Contributor Author

/run pipeline

akocbek
akocbek requested changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@akocbek akocbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check input "users" in security DA as well and sync with redis
auto_scaling needs #autoscaling in a link (security)

solutions/fully-configurable/variables.tf
}

variable "skip_es_kms_auth_policy" {
variable "skip_elasticsearch_kms_auth_policy" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, we need to change in redis

@whoffler
Copy link
Contributor Author

/run pipeline

@akocbek
Copy link
Contributor

akocbek commented Jun 27, 2025

/run pipeline

akocbek
akocbek approved these changes Jun 27, 2025
View reviewed changes
Copy link
Contributor

@akocbek akocbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ocofaigh ocofaigh merged commit b4e25c5 into main Jun 27, 2025
2 checks passed
@ocofaigh ocofaigh deleted the fullyConfigurable branch June 27, 2025 13:07
@terraform-ibm-modules-ops
Copy link
Contributor

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

aatreyee257 pushed a commit that referenced this pull request Jul 2, 2025
@whoffler @aatreyee257
feat: Full DA refactor (#428)
2cb1fe4 
BREAKING CHANGE: There is no supported upgrade path from `standard` to the new `Fully configurable` or `Security-enforced` DA variations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akocbek akocbek akocbek approved these changes

@daniel-butler-irl daniel-butler-irl Awaiting requested review from daniel-butler-irl daniel-butler-irl is a code owner

@shemau shemau Awaiting requested review from shemau shemau is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@whoffler @akocbek @terraform-ibm-modules-ops @ocofaigh