From e723a1849f5bf001a1de363989703ff3d40fbfaa Mon Sep 17 00:00:00 2001 From: akocbek Date: Tue, 18 Nov 2025 10:26:39 +0000 Subject: [PATCH 1/2] ci: remove CRA related files --- cra-config.yaml | 12 ------------ cra-tf-validate-ignore-rules.json | 10 ---------- 2 files changed, 22 deletions(-) delete mode 100644 cra-config.yaml delete mode 100644 cra-tf-validate-ignore-rules.json diff --git a/cra-config.yaml b/cra-config.yaml deleted file mode 100644 index a6b1a2e3..00000000 --- a/cra-config.yaml +++ /dev/null @@ -1,12 +0,0 @@ -# More info about this file at https://github.com/terraform-ibm-modules/common-pipeline-assets/blob/main/.github/workflows/terraform-test-pipeline.md#cra-config-yaml -version: "v1" -CRA_TARGETS: - - CRA_TARGET: "solutions/fully-configurable" # Target directory for CRA scan. If not provided, the CRA Scan will not be run. - CRA_IGNORE_RULES_FILE: "cra-tf-validate-ignore-rules.json" # CRA Ignore file to use. If not provided, it checks the repo root directory for `cra-tf-validate-ignore-rules.json` - PROFILE_ID: "fe96bd4d-9b37-40f2-b39f-a62760e326a3" # SCC profile ID (currently set to 'IBM Cloud Framework for Financial Services' '1.7.0' profile). - CRA_ENVIRONMENT_VARIABLES: # An optional map of environment variables for CRA, where the key is the variable name and value is the value. Useful for providing TF_VARs. - TF_VAR_existing_kms_instance_crn: "crn:v1:bluemix:public:hs-crypto:us-south:a/abac0df06b644a9cabc6e44f55b3880e:e6dce284-e80f-46e1-a3c1-830f7adff7a9::" - TF_VAR_existing_resource_group_name: "geretain-test-elasticsearch" - TF_VAR_kms_encryption_enabled: true - TF_VAR_provider_visibility: "public" - TF_VAR_prefix: "test" diff --git a/cra-tf-validate-ignore-rules.json b/cra-tf-validate-ignore-rules.json deleted file mode 100644 index 2809f91f..00000000 --- a/cra-tf-validate-ignore-rules.json +++ /dev/null @@ -1,10 +0,0 @@ -{ - "scc_rules": [ - { - "scc_rule_id": "rule-216e2449-27d7-4afc-929a-b66e196a9cf9", - "description": "Check whether Flow Logs for VPC are enabled", - "ignore_reason": "This rule is not relevant to the module itself, just the VPC resource is used in the example that is scanned", - "is_valid": false - } - ] -} From db7b06416c2e7922f1f2c37e9080be5d3e1a6373 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Conall=20=C3=93=20Cofaigh?= Date: Tue, 18 Nov 2025 13:48:55 +0000 Subject: [PATCH 2/2] Update ci.yml --- .github/workflows/ci.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2023dd79..95b2acb9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,6 +10,3 @@ jobs: call-terraform-ci-pipeline: uses: terraform-ibm-modules/common-pipeline-assets/.github/workflows/common-terraform-module-ci-v2.yml@v1.24.0 secrets: inherit - with: - craSCCv2: true - craConfigYamlFile: "cra-config.yaml"