fix: remove null optional elements before jsonencode is called (resolves this [bug](terraform-ibm-modules/terraform-ibm-icd-postgresql#273) (#37)

Author: akocbek

examples/complete/README.md

@@ -5,4 +5,5 @@ An end-to-end example that provisions the following infrastructure:
 - A resource group, if one is not passed in.
 - A Key Protect instance with a root key.
 - An instance of Databases for etcd with BYOK encryption and autoscaling.
+- Set 250 max connection for Databases for etcd instance.
 - Service credentials for the database instance.

examples/complete/main.tf

@@ -42,4 +42,7 @@ module "etcd_db" {
   tags                       = var.resource_tags
   access_tags                = var.access_tags
   service_credential_names   = var.service_credential_names
+  configuration = {
+    max_connections = 250
+  }
 }

main.tf

@@ -51,7 +51,8 @@ resource "ibm_database" "etcd_db" {
   tags              = var.tags
   adminpassword     = var.admin_pass
   service_endpoints = var.service_endpoints
-  configuration     = var.configuration != null ? jsonencode(var.configuration) : null
+  # remove elements with null values: see https://github.com/terraform-ibm-modules/terraform-ibm-icd-postgresql/issues/273
+  configuration = var.configuration != null ? jsonencode({ for k, v in var.configuration : k => v if v != null }) : null
 
   key_protect_key           = var.kms_key_crn
   backup_encryption_key_crn = local.backup_encryption_key_crn

module-metadata.json

@@ -456,7 +456,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 174
+        "line": 175
       }
     },
     "ibm_resource_tag.etcd_tag": {
@@ -472,7 +472,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 123
+        "line": 124
       }
     }
   },
@@ -492,7 +492,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 202
+        "line": 203
       }
     }
   },
@@ -571,7 +571,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 134
+        "line": 135
       }
     }
   }

tests/pr_test.go

@@ -100,6 +100,8 @@ func TestRunCompleteUpgradeExample(t *testing.T) {
 	})
 
 	output, err := options.RunTestUpgrade()
-	assert.Nil(t, err, "This should not have errored")
-	assert.NotNil(t, output, "Expected some output")
+	if !options.UpgradeTestSkipped {
+		assert.Nil(t, err, "This should not have errored")
+		assert.NotNil(t, output, "Expected some output")
+	}
 }