fix: remove null optional elements before jsonencode is called (resolves this [bug](terraform-ibm-modules/terraform-ibm-icd-postgresql#273) (#223)

Author: akocbek

examples/complete/README.md

@@ -5,6 +5,7 @@ An end-to-end example that uses the IBM Cloud Terraform provider to create the f
 - A resource group, if one is not passed in.
 - A Key Protect instance with a root key.
 - An instance of Databases for MongoDB with BYOK encryption.
+- Set 250 max connection for Databases for MongoDB instance.
 - Service credentials for the database instance.
 - A sample virtual private cloud (VPC).
 - A context-based restriction (CBR) rule to only allow MongoDB to be accessible from within the VPC.

examples/complete/main.tf

@@ -83,6 +83,9 @@ module "mongodb" {
   access_tags                = var.access_tags
   tags                       = var.resource_tags
   service_credential_names   = var.service_credential_names
+  configuration = {
+    max_connections = 250
+  }
   cbr_rules = [
     {
       description      = "${var.prefix}-mongodb access only from vpc"

main.tf

@@ -45,18 +45,19 @@ resource "time_sleep" "wait_for_authorization_policy" {
 }
 
 resource "ibm_database" "mongodb" {
-  depends_on                = [ibm_iam_authorization_policy.kms_policy]
-  name                      = var.instance_name
-  location                  = var.region
-  plan                      = var.plan
-  service                   = "databases-for-mongodb"
-  version                   = var.mongodb_version
-  resource_group_id         = var.resource_group_id
-  adminpassword             = var.admin_pass
-  tags                      = var.tags
-  service_endpoints         = var.endpoints
-  plan_validation           = var.plan_validation
-  configuration             = var.configuration != null ? jsonencode(var.configuration) : null
+  depends_on        = [ibm_iam_authorization_policy.kms_policy]
+  name              = var.instance_name
+  location          = var.region
+  plan              = var.plan
+  service           = "databases-for-mongodb"
+  version           = var.mongodb_version
+  resource_group_id = var.resource_group_id
+  adminpassword     = var.admin_pass
+  tags              = var.tags
+  service_endpoints = var.endpoints
+  plan_validation   = var.plan_validation
+  # remove elements with null values: see https://github.com/terraform-ibm-modules/terraform-ibm-icd-postgresql/issues/273
+  configuration             = var.configuration != null ? jsonencode({ for k, v in var.configuration : k => v if v != null }) : null
   key_protect_key           = var.kms_key_crn
   backup_encryption_key_crn = local.backup_encryption_key_crn
 

module-metadata.json

@@ -481,7 +481,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 182
+        "line": 183
       }
     },
     "ibm_resource_tag.mongodb_tag": {
@@ -497,7 +497,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 131
+        "line": 132
       }
     },
     "time_sleep.wait_for_authorization_policy": {
@@ -529,7 +529,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 210
+        "line": 211
       }
     }
   },
@@ -608,7 +608,7 @@
       },
       "pos": {
         "filename": "main.tf",
-        "line": 142
+        "line": 143
       }
     }
   }